Solr
  1. Solr
  2. SOLR-3345

BaseDistributedSearchTestCase should always ignore QTime

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA
    • Fix Version/s: 4.10, Trunk
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      The existing subclasses of BaseDistributedSearchTestCase all skip QTime. I can't see any way in which those numbers will ever match. Why not make this the default, or only, behavior?

      (This is really a question, in that I will provide a patch if no one tells me that it is a bad idea.)

      1. SOLR-3345.patch
        23 kB
        Vamsee Yarlagadda
      2. SOLR-3345-SVN.patch
        18 kB
        Vamsee Yarlagadda

        Issue Links

          Activity

          Benson Margulies created issue -
          Hide
          Tommaso Teofili added a comment -

          it sounds reasonable to me making that the default for BaseDistributedSearchTestCase

          Show
          Tommaso Teofili added a comment - it sounds reasonable to me making that the default for BaseDistributedSearchTestCase
          Hide
          Mark Miller added a comment -

          +1

          Show
          Mark Miller added a comment - +1
          Hide
          Chris Russell added a comment -

          I was just trying to write a new unit test and I ran into this. junit.framework.AssertionFailedError: .responseHeader.QTime:40!=84
          D:

          Show
          Chris Russell added a comment - I was just trying to write a new unit test and I ran into this. junit.framework.AssertionFailedError: .responseHeader.QTime:40!=84 D:
          Hide
          Vamsee Yarlagadda added a comment -

          This patch will ensure that QTime value check gets skipped(as there is no guarantee that the value will match) at the BaseDistributedSearchTestCase rather than at test level.

          Note this patch will only ignore checking the value but the presence of tag "QTime" will be checked in the response.

          Ran all unit tests in trunk and everything passed.

          Show
          Vamsee Yarlagadda added a comment - This patch will ensure that QTime value check gets skipped(as there is no guarantee that the value will match) at the BaseDistributedSearchTestCase rather than at test level. Note this patch will only ignore checking the value but the presence of tag "QTime" will be checked in the response. Ran all unit tests in trunk and everything passed.
          Vamsee Yarlagadda made changes -
          Field Original Value New Value
          Attachment SOLR-3345.patch [ 12656412 ]
          Mark Miller made changes -
          Assignee Mark Miller [ markrmiller@gmail.com ]
          Hide
          Mark Miller added a comment -

          Could you put up an SVN patch Vamsee? I'm having a tough time getting this to apply to an SVN checkout properly.

          Show
          Mark Miller added a comment - Could you put up an SVN patch Vamsee? I'm having a tough time getting this to apply to an SVN checkout properly.
          Vamsee Yarlagadda made changes -
          Attachment SOLR-3345-SVN.patch [ 12656991 ]
          Hide
          Vamsee Yarlagadda added a comment -

          Mark Miller Attached the SVN patch.
          Thanks!

          Show
          Vamsee Yarlagadda added a comment - Mark Miller Attached the SVN patch. Thanks!
          Vamsee Yarlagadda made changes -
          Remote Link This issue links to "Review request (Web Link)" [ 16220 ]
          Hide
          ASF subversion and git services added a comment -

          Commit 1612585 from Mark Miller in branch 'dev/trunk'
          [ https://svn.apache.org/r1612585 ]

          SOLR-3345: BaseDistributedSearchTestCase should always ignore QTime.

          Show
          ASF subversion and git services added a comment - Commit 1612585 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1612585 ] SOLR-3345 : BaseDistributedSearchTestCase should always ignore QTime.
          Hide
          ASF subversion and git services added a comment -

          Commit 1612593 from Mark Miller in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1612593 ]

          SOLR-3345: BaseDistributedSearchTestCase should always ignore QTime.

          Show
          ASF subversion and git services added a comment - Commit 1612593 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1612593 ] SOLR-3345 : BaseDistributedSearchTestCase should always ignore QTime.
          Hide
          Mark Miller added a comment -

          Thanks Vamsee and Benson!

          Show
          Mark Miller added a comment - Thanks Vamsee and Benson!
          Mark Miller made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 5.0 [ 12321664 ]
          Fix Version/s 4.10 [ 12327122 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Mark Miller
              Reporter:
              Benson Margulies
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development