Solr
  1. Solr
  2. SOLR-3331

solr NOTICE.txt is missing information

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6
    • Component/s: None
    • Labels:
      None

      Description

      Solr depends on some modules from lucene, and is released separately (as a source release including lucene),
      thus its NOTICE.txt has a lucene section which includes notices from lucene:

      =========================================================================
      ==  Apache Lucene Notice                                               ==
      =========================================================================
      

      however, its missing the IPADIC (which is required to be there).

      Furthermore, there is no way to check this, except via manual inspection.

      This gets complicated in 4.0 because of modularization, but we need to fix the
      3.6 situation in order to release (hence, this issue is set to 3.6 only and
      we can open a separate issue for 4.0 and discuss things like modules there,
      its irrelevant here).

      My proposal for 3.6 is:
      1. add the IPADIC notice
      2. have smoketester.py look for this specific block of text indicating
      the notices from lucene, and cross check them to ensure everything is consistent.

      1. SOLR-3331.patch
        21 kB
        Robert Muir
      2. SOLR-3331.patch
        84 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        I'll fix smoke tester...

        I already have a bunch of mods to add other checks to it...

        Show
        Michael McCandless added a comment - I'll fix smoke tester... I already have a bunch of mods to add other checks to it...
        Hide
        Robert Muir added a comment -

        Thanks Mike for helping with the python: i think we can fix the
        smoketester first (so we add the test), and then fix this NOTICE.txt until its happy

        Show
        Robert Muir added a comment - Thanks Mike for helping with the python: i think we can fix the smoketester first (so we add the test), and then fix this NOTICE.txt until its happy
        Hide
        Michael McCandless added a comment -

        Patch for smoke tester... it includes NOTICE checking and a bunch of other additions.. not sure it works yet!

        Show
        Michael McCandless added a comment - Patch for smoke tester... it includes NOTICE checking and a bunch of other additions.. not sure it works yet!
        Hide
        Robert Muir added a comment -

        Mike's patch, for 3.x, with fixed NOTICE.txt and smoketester-checks.

        Show
        Robert Muir added a comment - Mike's patch, for 3.x, with fixed NOTICE.txt and smoketester-checks.
        Hide
        Robert Muir added a comment -

        Thanks also for the smokeTester.py changes.

        I'm going to commit this to fix licensing.

        Note: the solr example test is going to be broken on windows,
        but thats ok, the smoketester is just a tool and is not part of the release
        (bugs in it cannot block releases).

        Show
        Robert Muir added a comment - Thanks also for the smokeTester.py changes. I'm going to commit this to fix licensing. Note: the solr example test is going to be broken on windows, but thats ok, the smoketester is just a tool and is not part of the release (bugs in it cannot block releases).

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development