Solr
  1. Solr
  2. SOLR-3327

Logging UI should indicate which loggers are set vs implicit

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: web gui
    • Labels:
      None

      Description

      The new logging UI looks great!
      http://localhost:8983/solr/#/~logging

      It would be nice to indicate which ones are set explicitly vs implicit – perhaps making the line bold when set=true

      1. SOLR-3327.patch
        1 kB
        Stefan Matheis (steffkes)
      2. logging.png
        7 kB
        Ryan McKinley
      3. SOLR-3327.patch
        0.7 kB
        Stefan Matheis (steffkes)
      4. SOLR-3327.patch
        0.4 kB
        Stefan Matheis (steffkes)
      5. multiple.png
        11 kB
        Ryan McKinley

        Issue Links

          Activity

          Hide
          Stefan Matheis (steffkes) added a comment -

          First shot, is bold visible enough or do we need some other style of marker?

          Show
          Stefan Matheis (steffkes) added a comment - First shot, is bold visible enough or do we need some other style of marker?
          Hide
          Ryan McKinley added a comment -

          The bold looks good, but it seems like it is getting applied to more then just the things that are "set"

          For example, if I take the default config and change just the javax value, the text value looks right, but the level value gets bold for everything below it

          Show
          Ryan McKinley added a comment - The bold looks good, but it seems like it is getting applied to more then just the things that are "set" For example, if I take the default config and change just the javax value, the text value looks right, but the level value gets bold for everything below it
          Hide
          Jan Høydahl added a comment -

          This looks great!

          Two more comments about the logging GUI:

          • It should state on top that these are the JDK logging levels. If people switch logging through SLF4J it won't work
          • Clicking multiple lines without making a selection leaves hanging popups
          Show
          Jan Høydahl added a comment - This looks great! Two more comments about the logging GUI: It should state on top that these are the JDK logging levels. If people switch logging through SLF4J it won't work Clicking multiple lines without making a selection leaves hanging popups
          Hide
          Hoss Man added a comment -

          It should state on top that these are the JDK logging levels. If people switch logging through SLF4J it won't work

          i wonder if there is a way for the LoggingServlet (request handler?) to detect which SL4J binding is in use, and spit out a warning if it's not JDK, so the UI can conditionally display that warning if it exists.

          Show
          Hoss Man added a comment - It should state on top that these are the JDK logging levels. If people switch logging through SLF4J it won't work i wonder if there is a way for the LoggingServlet (request handler?) to detect which SL4J binding is in use, and spit out a warning if it's not JDK, so the UI can conditionally display that warning if it exists.
          Hide
          Ryan McKinley added a comment -

          we can actually support all the same stuff with Log4j

          It can also spit out a warning if the framework is not supported (for now, JUL/Log4j)

          Show
          Ryan McKinley added a comment - we can actually support all the same stuff with Log4j It can also spit out a warning if the framework is not supported (for now, JUL/Log4j)
          Hide
          Shawn Heisey added a comment -

          Is there any way to give users the slf4j level options and have those translated automatically behind the scenes into the correct levels for the framework that's actually in use?

          Show
          Shawn Heisey added a comment - Is there any way to give users the slf4j level options and have those translated automatically behind the scenes into the correct levels for the framework that's actually in use?
          Hide
          Ryan McKinley added a comment -

          Is there any way to give users the slf4j level options

          Not easily; SLF4j only helps to set the level – it has no way to ask what the current level is, this is done with the relevant framework.

          Show
          Ryan McKinley added a comment - Is there any way to give users the slf4j level options Not easily; SLF4j only helps to set the level – it has no way to ask what the current level is, this is done with the relevant framework.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Thanks for the hint Ryan, updated Patch attached.

          Show
          Stefan Matheis (steffkes) added a comment - Thanks for the hint Ryan, updated Patch attached.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Oh noez, didn't realize - the js-part of the last patch got already committed yesterday while committing SOLR-3356. updated patch contains only css now

          Show
          Stefan Matheis (steffkes) added a comment - Oh noez, didn't realize - the js-part of the last patch got already committed yesterday while committing SOLR-3356 . updated patch contains only css now
          Hide
          Stefan Matheis (steffkes) added a comment -

          Okay, i just committed the remaining css-part of the patch in r1326529 . Should be okay now?

          Show
          Stefan Matheis (steffkes) added a comment - Okay, i just committed the remaining css-part of the patch in r1326529 . Should be okay now?
          Hide
          Ryan McKinley added a comment -

          style looks good. thanks!

          The issue Jan points to – where you can select multiple dialog windows is still there. See:

          Show
          Ryan McKinley added a comment - style looks good. thanks! The issue Jan points to – where you can select multiple dialog windows is still there. See:
          Hide
          Stefan Matheis (steffkes) added a comment -

          Oh yep, right. I've created SOLR-3364 to keep track on that. Will close this one

          Show
          Stefan Matheis (steffkes) added a comment - Oh yep, right. I've created SOLR-3364 to keep track on that. Will close this one

            People

            • Assignee:
              Stefan Matheis (steffkes)
              Reporter:
              Ryan McKinley
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development