Solr
  1. Solr
  2. SOLR-3326

Convert plugin documentation links to real links

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: web gui
    • Labels:
      None

      Description

      Right now when we show the plugin info, links are just plaintext. For:
      http://localhost:8983/solr/#/singlecore/plugins/other?entry=org.apache.solr.handler.component.QueryElevationComponent

      we see:

      src:   $URL: https:/​/​svn.apache.org/​repos/​asf/​lucene/​dev/​trunk/​solr/​core/​src/​java/​org/​apache/​solr/​handler/​component/​QueryElevationComponent.java $
      docs:  http://wiki.apache.org/solr/QueryElevationComponent 
      

      It would be great if that actually linked to the URLS.

      perhaps using something like:
      https://code.google.com/p/jquery-linkifier/source/browse/jquery.gn.linkifier.js

      1. SOLR-3326-convert-links.patch
        4 kB
        Ryan McKinley
      2. SOLR-3326-convert-links.patch
        5 kB
        Ryan McKinley
      3. SOLR-3326-convert-links.patch
        6 kB
        Ryan McKinley

        Issue Links

          Activity

          Ryan McKinley created issue -
          Ryan McKinley made changes -
          Field Original Value New Value
          Link This issue is related to SOLR-3238 [ SOLR-3238 ]
          Hide
          Ryan McKinley added a comment -

          here is a patch that uses:
          https://github.com/lolos/jquery-Linker/

          strangely it is not changing the https links though.

          Also, the links should probably use a different class so they show up differently

          Show
          Ryan McKinley added a comment - here is a patch that uses: https://github.com/lolos/jquery-Linker/ strangely it is not changing the https links though. Also, the links should probably use a different class so they show up differently
          Ryan McKinley made changes -
          Attachment SOLR-3326-convert-links.patch [ 12521582 ]
          Hide
          Ryan McKinley added a comment -

          this patch actually works on most of the links.

          The problem was with:

          detail_value.replace( /,/g, ',​' );
          

          when I comment that out, the links work great.

          I added a style for the links... but it is pretty crappy.

          stefan, can you take a look and fix the class?

          Go ahead and commit if things look OK to you

          Show
          Ryan McKinley added a comment - this patch actually works on most of the links. The problem was with: detail_value.replace( /,/g, ',​' ); when I comment that out, the links work great. I added a style for the links... but it is pretty crappy. stefan, can you take a look and fix the class? Go ahead and commit if things look OK to you
          Ryan McKinley made changes -
          Attachment SOLR-3326-convert-links.patch [ 12521598 ]
          Hide
          Ryan McKinley added a comment -

          OK, i think this one is good – except for the ugly link class

          Stefan, can you take a look? change anything that looks crazy. My JS foo is not so good!

          Show
          Ryan McKinley added a comment - OK, i think this one is good – except for the ugly link class Stefan, can you take a look? change anything that looks crazy. My JS foo is not so good!
          Ryan McKinley made changes -
          Attachment SOLR-3326-convert-links.patch [ 12521608 ]
          Hide
          Ryan McKinley added a comment -

          real links in #1310532

          Show
          Ryan McKinley added a comment - real links in #1310532
          Ryan McKinley made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Ryan McKinley [ ryantxu ]
          Resolution Fixed [ 1 ]
          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Ryan McKinley
              Reporter:
              Ryan McKinley
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development