Solr
  1. Solr
  2. SOLR-3324

Put field name/type in the analysis URL

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: web gui
    • Labels:
      None

      Description

      It would be nice to be able to link directly to a page that loads the right field in the analysis UI.

      This will also let us link the query-browser page to the analysis page

      1. SOLR-3324.patch
        8 kB
        Stefan Matheis (steffkes)
      2. SOLR-3324.patch
        1 kB
        Stefan Matheis (steffkes)

        Issue Links

          Activity

          Hide
          Hoss Man added a comment -

          this isn't just a nice to have – it's necessary for the tutorial

          Show
          Hoss Man added a comment - this isn't just a nice to have – it's necessary for the tutorial
          Hide
          Ryan McKinley added a comment -

          We may also consider some way to post a document to the analysis request handler.

          Even linking directly to the response would be helpful

          Show
          Ryan McKinley added a comment - We may also consider some way to post a document to the analysis request handler. Even linking directly to the response would be helpful
          Hide
          Stefan Matheis (steffkes) added a comment -

          This patch allows: /analysis?analysis.fieldvalue=index&analysis.query=query&type_or_name=text_rev - will set the form-fields to the given values and execute the Analysis

          Show
          Stefan Matheis (steffkes) added a comment - This patch allows: /analysis?analysis.fieldvalue=index&analysis.query=query&type_or_name=text_rev - will set the form-fields to the given values and execute the Analysis
          Hide
          Ryan McKinley added a comment -

          This looks good – can the URL update when you click "Analyse Values" so that it is easy to know the bookmarkable URL?

          Can verbose also be in the URL?

          Looking at this a bit more, how does 'type_or_name' work? I have field names that are the same as the type name – typically they use the same type, so it does not really matter... but it seems better to avoid that assumption.

          Perhaps the param could look like:
          f=type.pint
          or
          f=name.id

          Show
          Ryan McKinley added a comment - This looks good – can the URL update when you click "Analyse Values" so that it is easy to know the bookmarkable URL? Can verbose also be in the URL? Looking at this a bit more, how does 'type_or_name' work? I have field names that are the same as the type name – typically they use the same type, so it does not really matter... but it seems better to avoid that assumption. Perhaps the param could look like: f=type.pint or f=name.id
          Hide
          Stefan Matheis (steffkes) added a comment -

          Yep, will work on this .. have to changed to logic how the form is currently handeld a bit, but show be not that complicated to integrate that - also your other suggestions, ryan

          Show
          Stefan Matheis (steffkes) added a comment - Yep, will work on this .. have to changed to logic how the form is currently handeld a bit, but show be not that complicated to integrate that - also your other suggestions, ryan
          Hide
          Stefan Matheis (steffkes) added a comment -

          Next try :> Submitting the Form will change the URL, afterwards the Analysis-Process is executed.

          Can verbose also be in the URL?

          In Theory, yes .. right know, changing the state of verbose doesn't need to trigger a reload, it will only show additional informations in the results - they will be requested in every case, we just show them, if the box is checked. Will see how we can handle this

          Show
          Stefan Matheis (steffkes) added a comment - Next try :> Submitting the Form will change the URL, afterwards the Analysis-Process is executed. Can verbose also be in the URL? In Theory, yes .. right know, changing the state of verbose doesn't need to trigger a reload, it will only show additional informations in the results - they will be requested in every case, we just show them, if the box is checked. Will see how we can handle this
          Hide
          Ryan McKinley added a comment -

          Stefan – looks great. added in r1326690

          For the verbose field – i don't think it needs to trigger a reload when you click it. But it would be nice to have it in the URL after you click the button.

          Show
          Ryan McKinley added a comment - Stefan – looks great. added in r1326690 For the verbose field – i don't think it needs to trigger a reload when you click it. But it would be nice to have it in the URL after you click the button.
          Hide
          Stefan Matheis (steffkes) added a comment -

          But it would be nice to have it in the URL after you click the button

          Right, but this is how the sammy.js library works .. changing the URL will automatically trigger a reload. perhaps we can avoid this. work around, somehow ;>

          Show
          Stefan Matheis (steffkes) added a comment - But it would be nice to have it in the URL after you click the button Right, but this is how the sammy.js library works .. changing the URL will automatically trigger a reload. perhaps we can avoid this. work around, somehow ;>
          Hide
          Stefan Matheis (steffkes) added a comment -

          perhaps we can avoid this

          I checked this yesterday .. right now, the answer is simple: we can't. the browser is listening on the 'hashchange' event, which is triggered if we change the url (especially the hash, everything after the hash)

          So, we can change it .. then it will reload the page every time you toggle the verbose-option, but we have the setting in the url. don't know what is more important? a responsive UI or the possibility to bookmark the complete option-set?

          Show
          Stefan Matheis (steffkes) added a comment - perhaps we can avoid this I checked this yesterday .. right now, the answer is simple: we can't. the browser is listening on the 'hashchange' event, which is triggered if we change the url (especially the hash, everything after the hash) So, we can change it .. then it will reload the page every time you toggle the verbose-option, but we have the setting in the url. don't know what is more important? a responsive UI or the possibility to bookmark the complete option-set?

            People

            • Assignee:
              Ryan McKinley
              Reporter:
              Ryan McKinley
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development