Solr
  1. Solr
  2. SOLR-3317

Admin UI: Improve request handler / qt in query form

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: web gui
    • Labels:
      None

      Description

      The query form in the admin UI could use an improvement regarding how the request handler is chosen; presently all there is is a text input for 'qt'. The first choice to make in the form above the query should really be the request handler since it actually handles the request before any other parameters do anything. I think it'd be nice if it was filled with "/select" by default to make it very clear what's there, although I realize most of this query form seems to prefer blank values as defaults. When the form creates the URL to submit to Solr for the search, it needs to do something different depending on wether this value starts with a '/'. If it does, this goes where "/select" goes in the URL normally (i.e. it's the tail end of the path after the core). If it doesn't then it goes into the 'qt' URL parameter.

      I did something similar to the old 3x UI in SOLR-3161 that got committed to 3.6.

      1. SOLR-3317.patch
        2 kB
        Stefan Matheis (steffkes)
      2. SOLR-3317.patch
        8 kB
        David Smiley
      3. SOLR-3317.patch
        10 kB
        Stefan Matheis (steffkes)

        Issue Links

          Activity

          Hide
          Stefan Matheis (steffkes) added a comment -

          Committed in r1328681.

          Show
          Stefan Matheis (steffkes) added a comment - Committed in r1328681.
          Hide
          Stefan Matheis (steffkes) added a comment -

          There we go, updated Patch attached

          Regarding Chosen: Yes, it's mainly to be consistent over the complete UI. But i agree, the argument about multiple Handlers was a bit lame ;>

          Show
          Stefan Matheis (steffkes) added a comment - There we go, updated Patch attached Regarding Chosen: Yes, it's mainly to be consistent over the complete UI. But i agree, the argument about multiple Handlers was a bit lame ;>
          Hide
          David Smiley added a comment -

          I'm glad to hear you agree, and further suggested moving this setting above the "common" section; I thought the same. Lets do it!

          RE "Chosen" – that's a cool JS library I didn't know about; thanks for sharing. But it strikes me as way overkill for a select list that isn't going to be that long, particularly once it's paired down to the search oriented ones. An argument could be made for consistency in look and feel, however, if all select boxes in the UI are going in this direction, though.

          Show
          David Smiley added a comment - I'm glad to hear you agree, and further suggested moving this setting above the "common" section; I thought the same. Lets do it! RE "Chosen" – that's a cool JS library I didn't know about; thanks for sharing. But it strikes me as way overkill for a select list that isn't going to be that long, particularly once it's paired down to the search oriented ones. An argument could be made for consistency in look and feel, however, if all select boxes in the UI are going in this direction, though.
          Hide
          Stefan Matheis (steffkes) added a comment -

          The presence of 'qt' on this page bothers me just a little.

          Yes, i realized this already ;> I don't mind if we change it!

          What about the following: In preparation of changing the Handler-Selection, we move the current qt-Field to the top, over the "common"-Section and we name it "Request-Handler (qt)". That the used parameter (if needed) is named qt does not even matter, but w/o the "(qt)" addition i can already hear some "where is the qt-option questions" *gg

          JFYI: For the upcoming selection, i'd like to use Chosen (which is already in place for the Schema-Browser and the Analysis) - useful especially for those who have defined more than a few Handlers in their Instance.

          Show
          Stefan Matheis (steffkes) added a comment - The presence of 'qt' on this page bothers me just a little. Yes, i realized this already ;> I don't mind if we change it! What about the following: In preparation of changing the Handler-Selection, we move the current qt -Field to the top, over the "common"-Section and we name it "Request-Handler (qt)". That the used parameter (if needed) is named qt does not even matter, but w/o the "(qt)" addition i can already hear some "where is the qt-option questions" *gg JFYI: For the upcoming selection, i'd like to use Chosen (which is already in place for the Schema-Browser and the Analysis) - useful especially for those who have defined more than a few Handlers in their Instance.
          Hide
          David Smiley added a comment -

          Yeah, sounds good. If you feel so inclined you can add more tooltip help.

          The presence of 'qt' on this page bothers me just a little. The "request handler" will usually be specified as part of the URL, not a named qt parameter. But the labels for each of these things is done by a url parameter, not a spelled out version of what goes in that box (unlike the old admin form). So... not sure if anything could be done. What do you think of labeling it "Request-Handler (or qt)" ?

          Show
          David Smiley added a comment - Yeah, sounds good. If you feel so inclined you can add more tooltip help. The presence of 'qt' on this page bothers me just a little. The "request handler" will usually be specified as part of the URL, not a named qt parameter. But the labels for each of these things is done by a url parameter, not a spelled out version of what goes in that box (unlike the old admin form). So... not sure if anything could be done. What do you think of labeling it "Request-Handler (or qt)" ?
          Hide
          Stefan Matheis (steffkes) added a comment -

          David, i guess we could commit the patch and afterwards check for additional changes?

          Show
          Stefan Matheis (steffkes) added a comment - David, i guess we could commit the patch and afterwards check for additional changes?
          Hide
          Stefan Matheis (steffkes) added a comment -

          Why surround the labels to these fields in anchor tags when the label tag alone will work; right? Notice 'q' is done this way, unlike most fields. And if the anchor tags serve a useful purpose, then what does rel="help" add?

          The initial Idea was to add a link for every option to the related wiki-page .. therefore i already added an <a> Tag around them, which does nothing until it is used .. the rel-attribut would just be helpful if we start using it, because you can add specific action to all Links which match a[rel="help"] .. simple, but that's it ;>

          Show
          Stefan Matheis (steffkes) added a comment - Why surround the labels to these fields in anchor tags when the label tag alone will work; right? Notice 'q' is done this way, unlike most fields. And if the anchor tags serve a useful purpose, then what does rel="help" add? The initial Idea was to add a link for every option to the related wiki-page .. therefore i already added an <a> Tag around them, which does nothing until it is used .. the rel-attribut would just be helpful if we start using it, because you can add specific action to all Links which match a [rel="help"] .. simple, but that's it ;>
          Hide
          David Smiley added a comment -

          Looks good. I am supplying an updated patch with other changes/cleanup and some questions for you:

          • Some <div class="fieldset"> tags were not closed so I closed them.
          • Some id="..." attributes were not unique notably dismax & edismax since they share many parameters. So I added a differentiating prefix to keep them unique.
          • I added title="..." tags to some of the input elements to offer basic tooltip help. I didn't do all of them – I'm getting tired

          Question:

          • Why surround the labels to these fields in anchor tags when the label tag alone will work; right? Notice 'q' is done this way, unlike most fields. And if the anchor tags serve a useful purpose, then what does rel="help" add?
          Show
          David Smiley added a comment - Looks good. I am supplying an updated patch with other changes/cleanup and some questions for you: Some <div class="fieldset"> tags were not closed so I closed them. Some id="..." attributes were not unique notably dismax & edismax since they share many parameters. So I added a differentiating prefix to keep them unique. I added title="..." tags to some of the input elements to offer basic tooltip help. I didn't do all of them – I'm getting tired Question: Why surround the labels to these fields in anchor tags when the label tag alone will work; right? Notice 'q' is done this way, unlike most fields. And if the anchor tags serve a useful purpose, then what does rel="help" add?
          Hide
          Stefan Matheis (steffkes) added a comment -

          Um sorry, i thought this ticket was about something else - patch attached, David would you give a try?

          Show
          Stefan Matheis (steffkes) added a comment - Um sorry, i thought this ticket was about something else - patch attached, David would you give a try?
          Hide
          Stefan Matheis (steffkes) added a comment -

          Sorry David i've overlooked this one .. if you can, go for it! ty

          Show
          Stefan Matheis (steffkes) added a comment - Sorry David i've overlooked this one .. if you can, go for it! ty
          Hide
          David Smiley added a comment -

          Stefan; if you're too busy to do this then I will post a patch.

          Show
          David Smiley added a comment - Stefan; if you're too busy to do this then I will post a patch.

            People

            • Assignee:
              Stefan Matheis (steffkes)
              Reporter:
              David Smiley
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development