Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3301

Migrate enable/disable Ping from JSP to PingRequestHandler

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA
    • Fix Version/s: 4.0-ALPHA
    • Component/s: Admin UI
    • Labels:
      None

      Description

      My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run. This patch attaches the functionality to the PingRequestHandler. We debated creating a new HealthcheckRequestHandler as well. We added some basic unit tests.

        Attachments

        1. SOLR-3301-tests.patch
          0.8 kB
          Stefan Matheis (steffkes)
        2. SOLR-3301.patch
          16 kB
          Stefan Matheis (steffkes)
        3. PingRequestHandlerTest.java
          3 kB
          Eric Pugh
        4. ping_request_handler.patch
          3 kB
          Eric Pugh
        5. healthcheck-ui.png
          66 kB
          Matt Overstreet
        6. healthcheckenable.patch
          8 kB
          Matt Overstreet
        7. health_check_admin_consolidate2.patch
          17 kB
          Matt Overstreet
        8. health_check_admin_consolidate.patch
          17 kB
          Matt Overstreet

          Activity

            People

            • Assignee:
              steffkes Stefan Matheis (steffkes)
              Reporter:
              epugh Eric Pugh
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: