Solr
  1. Solr
  2. SOLR-3278

edismax support for negative boost with "bq" parameter

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA
    • Fix Version/s: 4.0-ALPHA
    • Component/s: query parsers
    • Labels:
      None

      Description

      Both "bf" and "bq" allow users to enter a boost value after the carrot, but only "bf" allows negative values. Here is a minor change and unit test to allow negative values on "bq" also.

        Issue Links

          Activity

          Hide
          James Dyer added a comment - - edited

          I'm assuming here that negative boosts with "bq" was simply overlooked in the past. If someone knows a good reason why this wasn't supported, or if this patch is naive, please let me know.

          Otherwise I will commit this.

          Show
          James Dyer added a comment - - edited I'm assuming here that negative boosts with "bq" was simply overlooked in the past. If someone knows a good reason why this wasn't supported, or if this patch is naive, please let me know. Otherwise I will commit this.
          Hide
          James Dyer added a comment -

          committed to Trunk: r1305908 .

          Show
          James Dyer added a comment - committed to Trunk: r1305908 .
          Hide
          Hoss Man added a comment -

          FYI: this change broke non-trivial bq expressions as noted in SOLR-3823, so i'm going to be rolling it back in that issue, and updating the added test along the lines of the recommendations on the wiki...

          bq = (*:* -xxx)^999 
          

          I've opened LUCENE-4378 to think about wether it really does make sense for the query syntax to allow negative boosts (the fact that it works with "bf" is really just a fluke)

          Show
          Hoss Man added a comment - FYI: this change broke non-trivial bq expressions as noted in SOLR-3823 , so i'm going to be rolling it back in that issue, and updating the added test along the lines of the recommendations on the wiki... bq = (*:* -xxx)^999 I've opened LUCENE-4378 to think about wether it really does make sense for the query syntax to allow negative boosts (the fact that it works with "bf" is really just a fluke)
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] Chris M. Hostetter
          http://svn.apache.org/viewvc?view=revision&revision=1383716

          SOLR-3823: Fix 'bq' parsing in edismax. Please note that this required reverting the negative boost support added by SOLR-3278 (merge r1383708)

          Show
          Commit Tag Bot added a comment - [branch_4x commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1383716 SOLR-3823 : Fix 'bq' parsing in edismax. Please note that this required reverting the negative boost support added by SOLR-3278 (merge r1383708)

            People

            • Assignee:
              James Dyer
              Reporter:
              James Dyer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development