Solr
  1. Solr
  2. SOLR-3262

Remove "threads" from DIH (Trunk only)

    Details

      Description

      SOLR-1352 introduced a multi-threading feature for DataImportHandler. Historically, this feature only seemed to work in a limited set of cases and I don't think we can guarantee users that using "threads" will behave consistently. Also, the multi-threaded option adds considerable complexity making code refactoring difficult.

      I propose removing "threads" from Trunk. (But keep it in 3.x, applying any bug fixes for it there.) This can be a first step in improving the DIH code base.

      Eventually we can possibly add a carefully though-out "threads" implementation back in.

        Activity

        James Dyer created issue -
        Hide
        Koji Sekiguchi added a comment -

        +1

        Show
        Koji Sekiguchi added a comment - +1
        Hide
        Chris Male added a comment -

        +1

        I think this should be a big priority for 4.0, so we don't release the code again.

        Show
        Chris Male added a comment - +1 I think this should be a big priority for 4.0, so we don't release the code again.
        James Dyer made changes -
        Field Original Value New Value
        Attachment SOLR-3262.patch [ 12519705 ]
        Hide
        James Dyer added a comment -

        Patch to remove "threads" from DIH. I would like to commit this in a few days.

        Show
        James Dyer added a comment - Patch to remove "threads" from DIH. I would like to commit this in a few days.
        James Dyer committed 1305384 (18 files)
        Reviews: none

        SOLR-3262: Remove "threads" from DIH

        Lucene trunk
        Hide
        James Dyer added a comment -

        committed. Trunk: r1305384

        Show
        James Dyer added a comment - committed. Trunk: r1305384
        James Dyer made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        James Dyer committed 1332293 (1 file)
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            James Dyer
            Reporter:
            James Dyer
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development