[SOLR-3217] refactor range faceting code so that the list of FieldTypes supported isn't hardcoded

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Chris M. Hostetter
• Created: 08/Mar/12 21:04
• Updated: 08/Mar/12 21:04

Description

idea that occured to me reviewing SOLR-2202, haven't thought it through all the way to be certain it would work...

1) create a new marker interface "RangeFacetable" which contains a single method getRangeEndpointCalculator(SchemaField)
2) refactor SimpleFacets so that instead of the big {{if (ft instanceof ...)

{ ... }

else if ....}} block there right now, we just check if the FieldType is an instance of RangeFacetable
3) use ft.getRangeEndpointCalculator to do the voodoo we curently doodoo
4) make all of the existing private static subclasses of RangeEndpointCalculator (like IntegerRangeEndpointCalculator) public top level classes so custom FieldTypes can use them

Issue Links

• relates to: SOLR-2202 Money/Currency FieldType