Solr
  1. Solr
  2. SOLR-3168

"numberToKeep" backups doesn't ever keep more than 1

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.5, 4.0-ALPHA
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: replication (java)
    • Labels:
      None

      Description

      On SOLR-2578, Neil Hooey pointed out a silly mistake in SnapShooter.java in that I forgot to increment a counter variable in the case the user wants to keep more than 1 backup.

      I will attach a patch for this 1-line fix. I do not intend to amend the unit test as this fix is easy to understand. Also, the test case is already very complex and long-running.

      I will commit shortly.

      1. SOLR-3168.patch
        0.5 kB
        James Dyer

        Activity

        Hide
        James Dyer added a comment -

        Committed r1294703 (Trunk) & r1294718 (3.x).

        Thanks, Neil.

        Show
        James Dyer added a comment - Committed r1294703 (Trunk) & r1294718 (3.x). Thanks, Neil.

          People

          • Assignee:
            James Dyer
            Reporter:
            James Dyer
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development