Solr
  1. Solr
  2. SOLR-3155

Zookeeper info servlet should use JSON library

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      Some of the JSON that the zookeeper info servlet spits out is not valid. Rather then try to fix it, I think we should just use an existing (tested!) json framework. the noggit writer is available, or maybe expose the solr JSONWriter

      1. SOLR-3155.patch
        18 kB
        Erick Erickson
      2. ZookeeperInfoServlet.java
        14 kB
        Stefan Matheis (steffkes)
      3. ZookeeperInfoServlet.java
        13 kB
        Ryan McKinley

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          1d 17h 38m 1 Erick Erickson 24/Feb/12 19:50
          Resolved Resolved Closed Closed
          440d 14h 49m 1 Uwe Schindler 10/May/13 11:39
          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue is depended upon by SOLR-3116 [ SOLR-3116 ]
          Gavin made changes -
          Link This issue blocks SOLR-3116 [ SOLR-3116 ]
          Erick Erickson made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 4.0 [ 12314992 ]
          Resolution Fixed [ 1 ]
          Hide
          Erick Erickson added a comment -

          Moving the rest of the new UI development to SOLR-3162

          Show
          Erick Erickson added a comment - Moving the rest of the new UI development to SOLR-3162
          Erick Erickson made changes -
          Link This issue is depended upon by SOLR-3162 [ SOLR-3162 ]
          Hide
          Erick Erickson added a comment -

          Committed to trunk, r: 1293039
          We'll let this bake a bit before closing this JIRA

          Show
          Erick Erickson added a comment - Committed to trunk, r: 1293039 We'll let this bake a bit before closing this JIRA
          Erick Erickson made changes -
          Attachment SOLR-3155.patch [ 12515858 ]
          Hide
          Erick Erickson added a comment -

          Patch rather than a raw Java file. Added sorting on the children of nodes.

          Show
          Erick Erickson added a comment - Patch rather than a raw Java file. Added sorting on the children of nodes.
          Stefan Matheis (steffkes) made changes -
          Attachment ZookeeperInfoServlet.java [ 12515743 ]
          Hide
          Stefan Matheis (steffkes) added a comment -

          I've changed the structure a little bit, so that i'll match the needed one for the additional Output on the Cloud-Tab (SOLR-3116)

          Show
          Stefan Matheis (steffkes) added a comment - I've changed the structure a little bit, so that i'll match the needed one for the additional Output on the Cloud-Tab ( SOLR-3116 )
          Hide
          Stefan Matheis (steffkes) added a comment -

          I'll try to get it running on my machine and have a look at it, yep

          Show
          Stefan Matheis (steffkes) added a comment - I'll try to get it running on my machine and have a look at it, yep
          Ryan McKinley made changes -
          Attachment ZookeeperInfoServlet.java [ 12515718 ]
          Hide
          Ryan McKinley added a comment -

          Here is an updated version that uses the noggit library to write JSON

          I don't have a good zookeeper setup... stefan, can you test this?

          Show
          Ryan McKinley added a comment - Here is an updated version that uses the noggit library to write JSON I don't have a good zookeeper setup... stefan, can you test this?
          Ryan McKinley made changes -
          Link This issue blocks SOLR-3116 [ SOLR-3116 ]
          Ryan McKinley made changes -
          Field Original Value New Value
          Link This issue is related to SOLR-3151 [ SOLR-3151 ]
          Ryan McKinley created issue -

            People

            • Assignee:
              Unassigned
              Reporter:
              Ryan McKinley
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development