Solr
  1. Solr
  2. SOLR-3139

StreamingUpdateSolrServer doesn't send UpdateRequest.getParams()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: clients - java
    • Labels:
      None

      Description

      CommonsHttpSolrServer properly encodes the request's SolrParams depending on GET or POST. However, StreamingUpdateSolrServer only looks at the params to determine whether they contain optimize/commit ops, and otherwise discards them.

      This is unexpected - it should properly encode and send SolrParams per request, in a similar way as CommonsHttpSolrServer does. Currently this bug prevents one from e.g. selecting a different update chain per request when using the streaming server.

        Activity

        Hide
        Sami Siren added a comment -

        Make params handling similar to what is done in HttpSolrServer.

        I am planning to commit this shortly.

        Show
        Sami Siren added a comment - Make params handling similar to what is done in HttpSolrServer. I am planning to commit this shortly.
        Hide
        Andrzej Bialecki added a comment -

        +1 looks good to me.

        Show
        Andrzej Bialecki added a comment - +1 looks good to me.

          People

          • Assignee:
            Sami Siren
            Reporter:
            Andrzej Bialecki
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development