Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3108

Error in SolrCloud's replica lookup code when replica's are hosted in same Solr instance

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: SolrCloud
    • Labels:
      None
    • Environment:

      Solr trunk as of today (r1241575)

      Description

      There's a small bug in ZkStateReader.getReplicaProps() when you have multiple replicas of the same shard/slice hosted in one CoreContainer. Not that you would often do this, but I was playing around with shards & replicas using just one Solr instance and noticed it. The attached patch should make it clear, the check on !coreNodeName.equals(filterNodeName) will always be false in such case.

      1. SOLR-3108.patch
        0.9 kB
        Bruno Dumon
      2. SOLR-3108.patch
        17 kB
        Mark Miller

        Activity

        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        Thanks Sami and Bruno!

        Show
        markrmiller@gmail.com Mark Miller added a comment - Thanks Sami and Bruno!
        Hide
        siren Sami Siren added a comment -

        Mark, your changes + test looks good to me. The way we can pass data to overseer (via CoreState) is a bit limited. I think we might want to move to different kind of mechanism later, for example a simple work queue hosted in zk. That would make things simpler both in overseer implementation and also the parts that need to pass information to overseer.

        Show
        siren Sami Siren added a comment - Mark, your changes + test looks good to me. The way we can pass data to overseer (via CoreState) is a bit limited. I think we might want to move to different kind of mechanism later, for example a simple work queue hosted in zk. That would make things simpler both in overseer implementation and also the parts that need to pass information to overseer.
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        I've committed the fix only for the moment since its very simple and straightforward.

        I'll let Sami take a peek at my changes to support the new test before committing that.

        Show
        markrmiller@gmail.com Mark Miller added a comment - I've committed the fix only for the moment since its very simple and straightforward. I'll let Sami take a peek at my changes to support the new test before committing that.
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        Bruno's fix + a test. To make the test I also did a little around the numShards handling so that you can pass it on core creation with the CoreAdminHandler. Sami, it would prob be good for you to review that a bit - I'm not sure if we can do that in a cleaner way or not?

        Show
        markrmiller@gmail.com Mark Miller added a comment - Bruno's fix + a test. To make the test I also did a little around the numShards handling so that you can pass it on core creation with the CoreAdminHandler. Sami, it would prob be good for you to review that a bit - I'm not sure if we can do that in a cleaner way or not?
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        Thanks Bruno - I'll take a look at this tomorrow.

        Show
        markrmiller@gmail.com Mark Miller added a comment - Thanks Bruno - I'll take a look at this tomorrow.

          People

          • Assignee:
            markrmiller@gmail.com Mark Miller
            Reporter:
            bruno Bruno Dumon
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development