Solr
  1. Solr
  2. SOLR-307

NGramFilterFactory and EdgeNGramFilterFactory

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3
    • Component/s: search
    • Labels:
      None

      Description

      Here is a patch that adds an NGramFilterFactory and EdgeNGramFilterFactory to Solr.

        Activity

        Hide
        Thomas Peuss added a comment -

        The patch against trunk.

        Show
        Thomas Peuss added a comment - The patch against trunk.
        Hide
        Otis Gospodnetic added a comment -

        Maybe it's just me and my Eclipse, but I had to remove @Override from the two create method before thing would compile. Yeah, must be my Eclipse settings, this compiled with ant compile. I'll commit in a bit, I just reformatted the code to fit https://issues.apache.org/jira/browse/SOLR-245 and removed some tabs.

        Show
        Otis Gospodnetic added a comment - Maybe it's just me and my Eclipse, but I had to remove @Override from the two create method before thing would compile. Yeah, must be my Eclipse settings, this compiled with ant compile. I'll commit in a bit, I just reformatted the code to fit https://issues.apache.org/jira/browse/SOLR-245 and removed some tabs.
        Hide
        Otis Gospodnetic added a comment -

        Eh, that abstract BaseTokenFilterFactory implements TokenFilterFactory interface, but does not implement (and keep abstract) its create(TokenStream) method, that must be why Eclipse is complaining. Should we add an abstract create(TokenStream) to BTFF class?

        Show
        Otis Gospodnetic added a comment - Eh, that abstract BaseTokenFilterFactory implements TokenFilterFactory interface, but does not implement (and keep abstract) its create(TokenStream) method, that must be why Eclipse is complaining. Should we add an abstract create(TokenStream) to BTFF class?
        Hide
        Yonik Seeley added a comment -

        Just remove @Override (since there isn't an implementation it's overriding, eclipse was correct to complain I guess).

        Show
        Yonik Seeley added a comment - Just remove @Override (since there isn't an implementation it's overriding, eclipse was correct to complain I guess).
        Hide
        Thomas Peuss added a comment -

        You are perfectly right. I am wondering why my Eclipse was not complaining.

        Show
        Thomas Peuss added a comment - You are perfectly right. I am wondering why my Eclipse was not complaining.
        Hide
        Otis Gospodnetic added a comment -

        Thanks Thomas, this is committed.

        Show
        Otis Gospodnetic added a comment - Thanks Thomas, this is committed.
        Hide
        Hoss Man added a comment -

        This bug was modified as part of a bulk update using the criteria...

        • Marked "Resolved" and "Fixed"
        • Had no "Fix Version" versions
        • Was listed in the CHANGES.txt for 1.3 as of today 2008-03-15

        The Fix Version for all 29 issues found was set to 1.3, email notification was suppressed to prevent excessive email.

        For a list of all the issues modified, search jira comments for this (hopefully) unique string: batch20070315hossman1

        Show
        Hoss Man added a comment - This bug was modified as part of a bulk update using the criteria... Marked "Resolved" and "Fixed" Had no "Fix Version" versions Was listed in the CHANGES.txt for 1.3 as of today 2008-03-15 The Fix Version for all 29 issues found was set to 1.3, email notification was suppressed to prevent excessive email. For a list of all the issues modified, search jira comments for this (hopefully) unique string: batch20070315hossman1

          People

          • Assignee:
            Unassigned
            Reporter:
            Thomas Peuss
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development