Solr
  1. Solr
  2. SOLR-3052

Typo in QueryComponent Distributed grouping parameter

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      The QueryComponent on line 388 and 409 has a typo in the name of a parameter which would likely cause problems:

      if (params.getBool("group.distibuted.first", false)) {
      

      the typo being "distibuted".

      Also, this param is not doc'd, so it would be good to add some docs on it.

        Activity

        Hide
        Martijn van Groningen added a comment -

        I think that this is something only devs need to know about. I'll make sure that it ends up in the jdocs.

        Show
        Martijn van Groningen added a comment - I think that this is something only devs need to know about. I'll make sure that it ends up in the jdocs.
        Hide
        Hoss Man added a comment -

        resolving since it looks like everything has been commited.

        Martijn: if you think it's something users should know about, i would add mention of it to the wiki ... if it's something only devs might want to be aware of then i would add it to the javadocs.

        either way we should go ahead and resolve this issue as fixed in 3.6 since that's where the change was made.

        Show
        Hoss Man added a comment - resolving since it looks like everything has been commited. Martijn: if you think it's something users should know about, i would add mention of it to the wiki ... if it's something only devs might want to be aware of then i would add it to the javadocs. either way we should go ahead and resolve this issue as fixed in 3.6 since that's where the change was made.
        Hide
        Martijn van Groningen added a comment - - edited

        I accidentally committed the typo fix in the commits for SOLR-3109. I'll add a changes entry in CHANGES.txt.
        Grant, what do you think is the right place to document these parameters? Wiki or jdocs?

        Show
        Martijn van Groningen added a comment - - edited I accidentally committed the typo fix in the commits for SOLR-3109 . I'll add a changes entry in CHANGES.txt. Grant, what do you think is the right place to document these parameters? Wiki or jdocs?
        Hide
        Martijn van Groningen added a comment -

        The typo also exists in SearchGroupsRequestFactory line 74...
        At least the typo is consistent

        The reason I never documented this parameter is because it was meant to be used internally by Solr (just like field sort values (fsv) parameter). But I can understand why people might want to use this.

        Show
        Martijn van Groningen added a comment - The typo also exists in SearchGroupsRequestFactory line 74... At least the typo is consistent The reason I never documented this parameter is because it was meant to be used internally by Solr (just like field sort values (fsv) parameter). But I can understand why people might want to use this.

          People

          • Assignee:
            Martijn van Groningen
            Reporter:
            Grant Ingersoll
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development