Solr
  1. Solr
  2. SOLR-3040

Avoid use of qt param for the DIH in the admin UI

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: web gui
    • Labels:
      None

      Description

      I really, really dislike that the qt parameter can used to refer to request handlers starting with a '/', especially for non-search handlers. The admin UI has one place I am aware of that attempts to do this, which is the DIH's admin page. Since we have two UIs in trunk, the new and old, there are actually two UIs where this occurs, and the old UI has two related files that need updating, in order to address this issue.

      An example URL generated by the UI today is this:
      http://localhost:8983/solr/rss/select?qt=/dataimport&command=show-config
      And here it is without using qt:
      http://localhost:8983/solr/rss/dataimport?command=show-config

      I do realize that fixing this issue as I do in my patch will make the UI not work if the DIH isn't registered with a leading '/', but honestly I wonder who if anyone out there does that. And even then, it's easily rectified.

        Issue Links

          Activity

          David Smiley created issue -
          David Smiley made changes -
          Field Original Value New Value
          Attachment SOLR-3040_avoid_qt_for_DIH_in_admin_ui.patch [ 12510816 ]
          David Smiley made changes -
          Link This issue relates to SOLR-1233 [ SOLR-1233 ]
          David Smiley made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Assignee David Smiley [ dsmiley ]
          Fix Version/s 3.6 [ 12319065 ]
          Fix Version/s 4.0 [ 12314992 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              David Smiley
              Reporter:
              David Smiley
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development