Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3032

Deprecate logOnce from SolrException

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None

      Description

      There seems to be a growing consensus (well, Muir and Hoss agree at least) that having this logOnce concept in SolrException is more trouble than it's worth. Point in case is that trunk (4x) fails to report anything useful in the log file when you define a custom component and don't have any <lib> statements going to the right place.

      So the proposal is to remove the whole logOnce process, supporting variables etc. The first step here will be deprecating the various bits of code in SolrException and starting to remove their usages.

      I'm opening this up for discussion, error reporting seems to be one of those things that generates endless discussion and I'd like them aired before putting too much work into this. My goal will be to have this in the code base by next Tuesday, so speak up.

        Attachments

        1. SOLR-3032.patch
          33 kB
          Erick Erickson
        2. SOLR-3032-3x.patch
          2 kB
          Erick Erickson

          Issue Links

            Activity

              People

              • Assignee:
                erickerickson Erick Erickson
                Reporter:
                erickerickson Erick Erickson
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: