Solr
  1. Solr
  2. SOLR-297

RequiredSolrParams.getField* don't fallback to non-field specific values

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3
    • Component/s: None
    • Labels:
      None

      Description

      as discussed here...

      http://www.nabble.com/semantics-of-RequiredSolrParams.getFieldParam%28%22field%22%2C%22param%22%29-tf4032370.html#a11455114

      the getFieldParam family of methods in RequiredSolrParams should not throw an exception if a non-field specific param value exists.

        Activity

        Hide
        Hoss Man added a comment -

        patch and tests.

        if no objections, i'll commit fairly soon (tonight... tomorrow...)

        Show
        Hoss Man added a comment - patch and tests. if no objections, i'll commit fairly soon (tonight... tomorrow...)
        Hide
        Ryan McKinley added a comment -

        looks good to me.

        perhaps change the issue title from "RequestSolrParams" to "RequiredSolrParams"

        Show
        Ryan McKinley added a comment - looks good to me. perhaps change the issue title from "RequestSolrParams" to "RequiredSolrParams"
        Hide
        Hoss Man added a comment -

        doh.

        Show
        Hoss Man added a comment - doh.
        Hide
        Hoss Man added a comment -

        Committed revision 555345.

        Show
        Hoss Man added a comment - Committed revision 555345.

          People

          • Assignee:
            Hoss Man
            Reporter:
            Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development