Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3
    • Component/s: search
    • Labels:
      None

      Description

      WHAT:
      A flag "noCacheIfLarger" is added to <queryResultWindowSize/> tag, i.e. <queryResultWindowSize noCacheIfLarger="true">50</queryResultWindowSize>. The flag can be omitted and the default is false.

      If this flag is set to true and user requires more results (in this case, start>=50), SolrIndexSearcher doesn't put the docList into queryResultCache.

      WHY(USE CASE):
      The Solr administrator can calculate max memory consumption for filterCache and documentCache as follows:

      filterCache: BitDocSet size * max size (cache entries)
      documentCache: average document size * max size (cache entries)

      however, the memory consumtion for queryResultCache is unpredictable.

      With this patch, if the administrator wants to control memory consumtion more strict, he can set queryResultWindowSize with noCacheIfLarger="true".

      1. SOLR-291.patch
        2 kB
        Koji Sekiguchi
      2. SOLR-291.patch
        2 kB
        Koji Sekiguchi

        Activity

        Hide
        Yonik Seeley added a comment -

        Thanks Koji, this has been in the back of my mind for a long time.
        Perhaps the cap should be independent of the queryResultWindowSize... perhaps something like
        <queryResultMaxDocsCached>250<queryResultMaxDocsCached>
        that will allow the first number of pages to be cached?

        Show
        Yonik Seeley added a comment - Thanks Koji, this has been in the back of my mind for a long time. Perhaps the cap should be independent of the queryResultWindowSize... perhaps something like <queryResultMaxDocsCached>250<queryResultMaxDocsCached> that will allow the first number of pages to be cached?
        Hide
        Koji Sekiguchi added a comment -

        I agree with you. It should be independent of WINDOW size. The new tag will be fine for me.

        Show
        Koji Sekiguchi added a comment - I agree with you. It should be independent of WINDOW size. The new tag will be fine for me.
        Hide
        Koji Sekiguchi added a comment -

        This patch uses <queryResultMaxDocsCached> tag to represent the max length of docList.

        Show
        Koji Sekiguchi added a comment - This patch uses <queryResultMaxDocsCached> tag to represent the max length of docList.
        Hide
        Yonik Seeley added a comment -

        Committed. Thanks Koji!

        Show
        Yonik Seeley added a comment - Committed. Thanks Koji!
        Hide
        Hoss Man added a comment -

        This bug was modified as part of a bulk update using the criteria...

        • Marked "Resolved" and "Fixed"
        • Had no "Fix Version" versions
        • Was listed in the CHANGES.txt for 1.3 as of today 2008-03-15

        The Fix Version for all 29 issues found was set to 1.3, email notification was suppressed to prevent excessive email.

        For a list of all the issues modified, search jira comments for this (hopefully) unique string: batch20070315hossman1

        Show
        Hoss Man added a comment - This bug was modified as part of a bulk update using the criteria... Marked "Resolved" and "Fixed" Had no "Fix Version" versions Was listed in the CHANGES.txt for 1.3 as of today 2008-03-15 The Fix Version for all 29 issues found was set to 1.3, email notification was suppressed to prevent excessive email. For a list of all the issues modified, search jira comments for this (hopefully) unique string: batch20070315hossman1

          People

          • Assignee:
            Unassigned
            Reporter:
            Koji Sekiguchi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development