Solr
  1. Solr
  2. SOLR-2850

Do not refine facets when minCount == 1

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: None
    • Labels:
      None
    • Environment:

      Ubuntu, distributed

      Description

      Currently there is a special case in the code to not refine facets if minCount==0. It seems this could be extended to minCount <= 1 as there would be no need to take the extra step to refine facets if minCount is 1.

      1. SOLR-2850.patch
        1 kB
        Adrien Grand
      2. SOLR-2850.patch
        1 kB
        Andrew Lundgren

        Activity

        Hide
        Andrew Lundgren added a comment - - edited

        Modify the code to not refine facets when it is not needed.

        While this issue exists all the way back into 3.4, at least, I just created the patch for branch/4x.

        Show
        Andrew Lundgren added a comment - - edited Modify the code to not refine facets when it is not needed. While this issue exists all the way back into 3.4, at least, I just created the patch for branch/4x.
        Hide
        Adrien Grand added a comment -

        Looks good. I've hit a similar issue with facet.sort=count so I updated your patch.

        Tests passed, I'll commit soon unless someone objects.

        Show
        Adrien Grand added a comment - Looks good. I've hit a similar issue with facet.sort=count so I updated your patch. Tests passed, I'll commit soon unless someone objects.
        Hide
        Adrien Grand added a comment -

        Committed. Thanks, Andrew!

        Show
        Adrien Grand added a comment - Committed. Thanks, Andrew!
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Adrien Grand
        http://svn.apache.org/viewvc?view=revision&revision=1442873

        SOLR-2850: Do not refine facets when minCount == 1 (merged from r1442872).

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Adrien Grand http://svn.apache.org/viewvc?view=revision&revision=1442873 SOLR-2850 : Do not refine facets when minCount == 1 (merged from r1442872).
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Adrien Grand
        http://svn.apache.org/viewvc?view=revision&revision=1442872

        SOLR-2850: Do not refine facets when minCount == 1.

        Show
        Commit Tag Bot added a comment - [trunk commit] Adrien Grand http://svn.apache.org/viewvc?view=revision&revision=1442872 SOLR-2850 : Do not refine facets when minCount == 1.

          People

          • Assignee:
            Unassigned
            Reporter:
            Matt Smith
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development