Solr
  1. Solr
  2. SOLR-2847

fix test bug in DistributedSpellCheckComponentTest

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.5, 4.0-ALPHA
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: multicore, spellchecker
    • Labels:
      None

      Description

      In Trunk, the IndexBasedSpellChecker dictionary is not being built both for the "control" and "shard" indexes. The test then compares nothing to nothing and passes, because both the shard-index response and the control-index responses are the same. This issue fixes the problem with the dictionaries not being built and also adds an additional check for data in the control-index responses so that this sort of regression may be detected in the future.

      1. SOLR-2847.patch
        4 kB
        James Dyer
      2. SOLR-2847.patch
        3 kB
        James Dyer

        Activity

        Hide
        James Dyer added a comment -

        updated patch fixes devious test bug. With this patch, if the "controlData" doesn't return any spellcheck responses, the test fails.

        Will commit soon & port to 3x. Figure this is a good practice-commit for me.

        Show
        James Dyer added a comment - updated patch fixes devious test bug. With this patch, if the "controlData" doesn't return any spellcheck responses, the test fails. Will commit soon & port to 3x. Figure this is a good practice-commit for me.
        Hide
        James Dyer added a comment - - edited

        Trunk: r1244553
        Branch_3x: r1244595

        Show
        James Dyer added a comment - - edited Trunk: r1244553 Branch_3x: r1244595

          People

          • Assignee:
            James Dyer
            Reporter:
            James Dyer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development