[SOLR-2819] Wrong isHex()-method in HTMLStripCharFilter

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.4
• Fix Version/s: 3.6, 4.0-ALPHA
• Assignee: Chris M. Hostetter
• Reporter: Bernhard Berger
• Created: 10/Oct/11 08:42
• Updated: 10/May/13 10:40
• Resolved: 29/Nov/11 19:26

Description

In org.apache.solr.analysis HTMLStripCharFilter use a wrong isHex()-method that return characters like 'X', 'Y' as valid hex chars:

  private boolean isHex(int ch) {
    return (ch>='0' && ch<='9') ||
           (ch>='A' && ch<='Z') ||
           (ch>='a' && ch<='z');
  }

If only characters from [0-9a-zA-Z] are allowed, the readNumericEntity method will detect faster a mismatch.