Solr
  1. Solr
  2. SOLR-2793

A SolrIndexSearcher can be left open if the executor rejects a task.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      This is starting to really bug me because tests almost never pass on my linux box due to this issue. Time to fix it.

        Activity

        Mark Miller created issue -
        Hide
        Mark Miller added a comment -

        patch simply decrefs newSearchHolder if the executor rejects the task

        Show
        Mark Miller added a comment - patch simply decrefs newSearchHolder if the executor rejects the task
        Mark Miller made changes -
        Field Original Value New Value
        Attachment SOLR-2793.patch [ 12496413 ]
        Hide
        Mark Miller added a comment -

        whoops - patch is slightly stale - what I will actually commit also propagates the exception - right after decref, throw e.

        Show
        Mark Miller added a comment - whoops - patch is slightly stale - what I will actually commit also propagates the exception - right after decref, throw e.
        markrmiller committed 1175637 (2 files)
        Reviews: none

        SOLR-2793: In rare cases (most likely during shutdown), a SolrIndexSearcher can be left open if the executor rejects a task.

        markrmiller committed 1175646 (1 file)
        Reviews: none

        SOLR-2793: Be sure to only dec ref if we inc ref'd

        Hide
        Mark Miller added a comment -

        As I'm stressing tests to track down other failures, I've learned of another subtlety in this - in some cases you need to decrement twice on error.

        Show
        Mark Miller added a comment - As I'm stressing tests to track down other failures, I've learned of another subtlety in this - in some cases you need to decrement twice on error.
        Hide
        Mark Miller added a comment -

        And of course this should be done for the other submits...just hit this same issue on a different submit call in the autocommit test...

        Show
        Mark Miller added a comment - And of course this should be done for the other submits...just hit this same issue on a different submit call in the autocommit test...
        markrmiller committed 1175651 (1 file)
        Reviews: none

        SOLR-2793: Somtimes you must dec ref twice, and add fix to the other submit calls

        Hide
        Simon Willnauer added a comment -

        mark, I see several commits for this issue - can we resolve this?

        Show
        Simon Willnauer added a comment - mark, I see several commits for this issue - can we resolve this?
        Hide
        Mark Miller added a comment -

        Open because I have not done it on 3.x yet, just trunk - I can try and do it tomorrow night, but it's certainly not critical (more a problem for tests than anything else), so could also go to 3.6 easily.

        Show
        Mark Miller added a comment - Open because I have not done it on 3.x yet, just trunk - I can try and do it tomorrow night, but it's certainly not critical (more a problem for tests than anything else), so could also go to 3.6 easily.
        Simon Willnauer made changes -
        Fix Version/s 3.6 [ 12319065 ]
        Fix Version/s 3.5 [ 12317876 ]
        Hide
        Lance Norskog added a comment -

        Is it possible that this bug was in Solr 1.4.1?

        Show
        Lance Norskog added a comment - Is it possible that this bug was in Solr 1.4.1?
        Robert Muir made changes -
        Fix Version/s 3.6 [ 12319065 ]
        Hide
        Mark Miller added a comment -

        not going to 3x at this point

        Show
        Mark Miller added a comment - not going to 3x at this point
        Mark Miller made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mark Miller
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development