Solr
  1. Solr
  2. SOLR-2793

A SolrIndexSearcher can be left open if the executor rejects a task.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      This is starting to really bug me because tests almost never pass on my linux box due to this issue. Time to fix it.

        Activity

        Hide
        Mark Miller added a comment -

        patch simply decrefs newSearchHolder if the executor rejects the task

        Show
        Mark Miller added a comment - patch simply decrefs newSearchHolder if the executor rejects the task
        Hide
        Mark Miller added a comment -

        whoops - patch is slightly stale - what I will actually commit also propagates the exception - right after decref, throw e.

        Show
        Mark Miller added a comment - whoops - patch is slightly stale - what I will actually commit also propagates the exception - right after decref, throw e.
        Hide
        Mark Miller added a comment -

        As I'm stressing tests to track down other failures, I've learned of another subtlety in this - in some cases you need to decrement twice on error.

        Show
        Mark Miller added a comment - As I'm stressing tests to track down other failures, I've learned of another subtlety in this - in some cases you need to decrement twice on error.
        Hide
        Mark Miller added a comment -

        And of course this should be done for the other submits...just hit this same issue on a different submit call in the autocommit test...

        Show
        Mark Miller added a comment - And of course this should be done for the other submits...just hit this same issue on a different submit call in the autocommit test...
        Hide
        Simon Willnauer added a comment -

        mark, I see several commits for this issue - can we resolve this?

        Show
        Simon Willnauer added a comment - mark, I see several commits for this issue - can we resolve this?
        Hide
        Mark Miller added a comment -

        Open because I have not done it on 3.x yet, just trunk - I can try and do it tomorrow night, but it's certainly not critical (more a problem for tests than anything else), so could also go to 3.6 easily.

        Show
        Mark Miller added a comment - Open because I have not done it on 3.x yet, just trunk - I can try and do it tomorrow night, but it's certainly not critical (more a problem for tests than anything else), so could also go to 3.6 easily.
        Hide
        Lance Norskog added a comment -

        Is it possible that this bug was in Solr 1.4.1?

        Show
        Lance Norskog added a comment - Is it possible that this bug was in Solr 1.4.1?
        Hide
        Mark Miller added a comment -

        not going to 3x at this point

        Show
        Mark Miller added a comment - not going to 3x at this point

          People

          • Assignee:
            Mark Miller
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development