Solr
  1. Solr
  2. SOLR-2791

Replication: abortfetch is broken if replication was started by fetchindex

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4, 4.0-ALPHA
    • Fix Version/s: 3.5, 4.0-ALPHA
    • Component/s: replication (java)
    • Labels:
      None

      Description

      If I start replication by issuing a "fetchindex" command with a "masterUrl" parameter, it seems to me (by looking at the trunk code) that "abortfetch" command would not do anything.
      It appears to be aborting only when replication is configured with hardcoded master/slave cores.

      The fix appears to be to use tempSnapPuller.abortPull always because tempSnapPuller is always the snap puller doing the actual work.

        Activity

        Hide
        Yury Kats added a comment -

        patch

        Show
        Yury Kats added a comment - patch
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 1175696 on trunk and 1175703 on branch_3x.

        Thanks Yury!

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 1175696 on trunk and 1175703 on branch_3x. Thanks Yury!
        Hide
        Uwe Schindler added a comment -

        Bulk close after 3.5 is released

        Show
        Uwe Schindler added a comment - Bulk close after 3.5 is released

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Yury Kats
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development