[SOLR-274] autoCommit maxDocs does not apply if maxTime is defined

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2
• Fix Version/s: 1.3
• Assignee: Mike Klaas
• Reporter: Mike Klaas
• Created: 25/Jun/07 17:47
• Updated: 10/May/13 10:40
• Resolved: 25/Jun/07 19:10

Description

the problem is in this block:

public void addedDocument() {
docsSinceCommit++;
lastAddedTime = System.currentTimeMillis();
if( pending == null ) { // Don't start a new event if one is already waiting
if( timeUpperBound > 0 )

{ pending = scheduler.schedule( this, timeUpperBound, TimeUnit.MILLISECONDS ); }

else if( docsUpperBound > 0 && (docsSinceCommit > docsUpperBound) )

{ // 1/4 second seems fast enough for anyone using maxDocs pending = scheduler.schedule( this, 250, TimeUnit.MILLISECONDS ); }

}
}

the docSinceCommit block is not triggered as a (long waiting) pending commit scheduled for maxTime.