[SOLR-2719] REGRESSION ReturnFields incorrect parse fields with hyphen - breaks existing "fl=my-field-name" type usecases

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 4.0-ALPHA
• Fix Version/s: 4.0-ALPHA
• Component/s: search
• Labels: field fl query queryparser
• Assignee: Yonik Seeley
• Reporter: Nik V. Babichev
• Created: 19/Aug/11 13:30
• Updated: 10/May/13 10:40
• Resolved: 13/Mar/12 20:08

Description

fl=my-hyphen-field in query params parsed as "my" instead of "my-hyphen-field".

OAS.search.ReturnFields use method getId() from OAS.search.QueryParsing
in which check chars "if (!Character.isJavaIdentifierPart(ch) && ch != '.')"
Hyphen is not JavaIdentifierPart and this check break when first "-" is found.

This problem solve by passing '-' to check:
if (!Character.isJavaIdentifierPart(ch) && ch != '.' && ch != '-') break;

But I don't know how it can affect on whole project.

Issue Links

• is broken by: SOLR-2444 Update fl syntax to support: pseudo fields, AS, transformers, and wildcards
• is duplicated by: SOLR-2815 Fields with a "-" in the name are interpreted as functions in the fl= parameter.
• relates to: SOLR-3207 Add field name validation