Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: Response Writers
    • Labels:
      None

      Description

      This stems from issues with SOLR-2588, moving the Velocity response writer back to contrib. We still want the example app to use the VelocityResponseWriter for the /browse interface. Many of Solr's core tests use the example Solr configuration. There are other contribs that are brought into the example app (extract, clustering, DIH, for examples) but these are request handlers that lazy load. Response writers don't currently lazy load, thus causing core tests that use the example config to fail unless "ant dist" is run.

      1. SOLR-2718-velocity-test-cleanup.patch
        3 kB
        Erik Hatcher
      2. SOLR-2718.patch
        9 kB
        Erik Hatcher

        Issue Links

          Activity

          Erik Hatcher created issue -
          Hide
          Erik Hatcher added a comment -

          Another option is to adjust the tests to not use the example solr-home - there's not that many of them. I'll investigate. We still want example tested somehow, but more at an integration level than a unit level.

          Show
          Erik Hatcher added a comment - Another option is to adjust the tests to not use the example solr-home - there's not that many of them. I'll investigate. We still want example tested somehow, but more at an integration level than a unit level.
          Hoss Man made changes -
          Field Original Value New Value
          Link This issue relates to SOLR-2588 [ SOLR-2588 ]
          Hide
          Hoss Man added a comment -

          adding a lazy load option to response writers seems like a good idea to me ... just want to make sure it defaults to false just like request handlers

          Show
          Hoss Man added a comment - adding a lazy load option to response writers seems like a good idea to me ... just want to make sure it defaults to false just like request handlers
          Hide
          Erik Hatcher added a comment -

          Here's a patch that implements lazy loaded response writers, along with a test. A little bit of copy/paste/adapt from the request handler lazy loading, so perhaps worth implementing some common infrastructure for this pattern?

          Show
          Erik Hatcher added a comment - Here's a patch that implements lazy loaded response writers, along with a test. A little bit of copy/paste/adapt from the request handler lazy loading, so perhaps worth implementing some common infrastructure for this pattern?
          Erik Hatcher made changes -
          Attachment SOLR-2718.patch [ 12501021 ]
          Hide
          Erik Hatcher added a comment -

          Here's a patch to clean up the hack made for SOLR-2588 due to the example configuration using the VelocityResponseWriter but it not (necessarily) built when tests are run. With lazy loaded response writers, no worries now.

          Show
          Erik Hatcher added a comment - Here's a patch to clean up the hack made for SOLR-2588 due to the example configuration using the VelocityResponseWriter but it not (necessarily) built when tests are run. With lazy loaded response writers, no worries now.
          Erik Hatcher made changes -
          Attachment SOLR-2718-velocity-test-cleanup.patch [ 12501023 ]
          Erik Hatcher made changes -
          Assignee Erik Hatcher [ ehatcher ]
          Fix Version/s 4.0 [ 12314992 ]
          Erik Hatcher made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Erik Hatcher added a comment -

          I've seen two reports from Solr 3.5 users today (via #solr in IRC) where they've deployed Solr into Tomcat and copied the example configuration. The lazy loading was not backported to 3.x and thus the registration of VRW causes a startup error when the libs aren't found.

          This needs to be ported/adapted to 3.x to ensure 3.6 doesn't have this issue.

          Show
          Erik Hatcher added a comment - I've seen two reports from Solr 3.5 users today (via #solr in IRC) where they've deployed Solr into Tomcat and copied the example configuration. The lazy loading was not backported to 3.x and thus the registration of VRW causes a startup error when the libs aren't found. This needs to be ported/adapted to 3.x to ensure 3.6 doesn't have this issue.
          Erik Hatcher made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Erik Hatcher added a comment -

          Fixed already on 4.0, but needs to be ported to 3.x too.

          Show
          Erik Hatcher added a comment - Fixed already on 4.0, but needs to be ported to 3.x too.
          Erik Hatcher made changes -
          Fix Version/s 3.6 [ 12319065 ]
          Steve Rowe made changes -
          Assignee Erik Hatcher [ ehatcher ] Steven Rowe [ steve_rowe ]
          sarowe committed 1233199 (1 file)
          Reviews: none

          SOLR-2718: Move CHANGES entry under 3.6.0

          Hide
          Steve Rowe added a comment -

          Backported to branch_3x and committed.

          Show
          Steve Rowe added a comment - Backported to branch_3x and committed.
          Steve Rowe made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Steve Rowe
              Reporter:
              Erik Hatcher
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development