[SOLR-2716] QueryResultKey hashCode() and equals() is dependent on filter order

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 3.3
• Component/s: search
• Assignee: Unassigned
• Reporter: Neil Prosser
• Created: 17/Aug/11 23:04
• Updated: 09/May/17 20:46
• Resolved: 09/May/17 20:46

Description

The hashCode() and equals() methods of a QueryResultKey are dependent on the order of the filters meaning that potentially identical result sets are missed when cached.

Query query = new TermQuery(new Term("field1", "value1"));
Query filter1 = new TermQuery(new Term("field2", "value2"));
Query filter2 = new TermQuery(new Term("field3", "value3"));

List<Query> filters1 = new ArrayList<Query>();
filters1.add(filter1);
filters1.add(filter2);

List<Query> filters2 = new ArrayList<Query>();
filters2.add(filter2);
filters2.add(filter1);

QueryResultKey key1 = new QueryResultKey(query, filters1, null, 0);
QueryResultKey key2 = new QueryResultKey(query, filters2, null, 0);

// Both the following assertions fail
assert key1.equals(key2);
assert key1.hashCode() == key2.hashCode();

Issue Links

• duplicates: SOLR-5057 queryResultCache should not related with the order of fq's list