Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      SOLR-2657 points out that all fields show up when you request score and something becides a 'normal' field. To support the strange behavior and avoid it when uncenessary we have this:

          if( fields.size() == 1 && _wantsScore && augmenters.size() == 1 && globs.isEmpty() ) {
            _wantsAllFields = true;
          }
      

      I suggest we advertise in 3.x that expecting fl=score to return all fields is deprecated, and remove this bit of crazy code from 4.x

        Issue Links

          Activity

          Hide
          Yonik Seeley added a comment -

          +1

          Show
          Yonik Seeley added a comment - +1
          Hide
          David Smiley added a comment -

          +1 I just ran into this today! I was about to file a bug.

          Show
          David Smiley added a comment - +1 I just ran into this today! I was about to file a bug.
          Hide
          Ryan McKinley added a comment -

          What is the right process to deprecate this behavior in 3.x?

          Is it just a note in the CHANGES.txt?

          We could also try to detect the behavior and log a warning... but i'm not sure that is worth much.

          Show
          Ryan McKinley added a comment - What is the right process to deprecate this behavior in 3.x? Is it just a note in the CHANGES.txt? We could also try to detect the behavior and log a warning... but i'm not sure that is worth much.
          Hide
          Yonik Seeley added a comment -

          I imagine it's a very rarely used "feature", as I don't think it's documented.
          http://wiki.apache.org/solr/CommonQueryParameters#fl

          A note in CHANGES in trunk may be all that's warranted?

          Show
          Yonik Seeley added a comment - I imagine it's a very rarely used "feature", as I don't think it's documented. http://wiki.apache.org/solr/CommonQueryParameters#fl A note in CHANGES in trunk may be all that's warranted?
          Hide
          Robert Muir added a comment -

          3.4 -> 3.5

          Show
          Robert Muir added a comment - 3.4 -> 3.5
          Hide
          Ryan McKinley added a comment -

          Added warning in 3.x #1298683
          removed from trunk in #1298690

          Show
          Ryan McKinley added a comment - Added warning in 3.x #1298683 removed from trunk in #1298690
          Hide
          Mark Miller added a comment -

          There was something missed here. I'll fix it when I fix the multiple fl's not being treated right in distrib search - around that same code there is still logic that expects this.

          Show
          Mark Miller added a comment - There was something missed here. I'll fix it when I fix the multiple fl's not being treated right in distrib search - around that same code there is still logic that expects this.

            People

            • Assignee:
              Ryan McKinley
              Reporter:
              Ryan McKinley
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development