Solr
  1. Solr
  2. SOLR-2697

commit and autocommit operations don't reset DirectUpdateHandler2.numDocsPending stats attribute

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4, 4.0-ALPHA
    • Fix Version/s: 4.0-ALPHA
    • Component/s: update
    • Labels:
      None

      Description

      commit and autocommit operations don't reset DirectUpdateHandler2.numDocsPending stats attribute (see attached screenshots)

      I believe this regression was caused by DUH2 refactorings (near realtime, etc). See commit https://github.com/apache/lucene-solr/commit/ffd9c717448eca895d19be8ee9718bc399ac34a7#diff-18

      1. SOLR-2697.patch
        1 kB
        Mark Miller
      2. SOLR-2697.patch
        0.5 kB
        Mark Miller
      3. SolrIndexOperations.png
        28 kB
        Alexey Serba
      4. UpdateHandlerDocsPending.png
        24 kB
        Alexey Serba

        Activity

        Hide
        Mark Miller added a comment -

        Hmm...I actually noticed this a week or two ago, but thought it was likely an existing issue from back when Solr tried to handle more of this type of tracking/buffering. I forgot about it before making an issue.

        But you are right - previously this was reset in the close writer method...but we no longer close the writer on commit.

        Show
        Mark Miller added a comment - Hmm...I actually noticed this a week or two ago, but thought it was likely an existing issue from back when Solr tried to handle more of this type of tracking/buffering. I forgot about it before making an issue. But you are right - previously this was reset in the close writer method...but we no longer close the writer on commit.
        Hide
        Mark Miller added a comment -

        Separately, we might track the number of docs pending for soft commit...

        Show
        Mark Miller added a comment - Separately, we might track the number of docs pending for soft commit...
        Hide
        Mark Miller added a comment -

        this was fixed

        Show
        Mark Miller added a comment - this was fixed

          People

          • Assignee:
            Mark Miller
            Reporter:
            Alexey Serba
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development