Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      First, there was only Document, then AddUpdateCommand added support for SolrInputDocument, and most document producers create SolrInputDocuments. But AddUpdateCommand continues to support both, leading to confusion and more work for update processors (which should they look at? both?). It seems like we should remove "Document" from AddUpdateCommand for the sake of consistency.

      1. SOLR-2685.patch
        19 kB
        Yonik Seeley

        Activity

        Hide
        Ryan McKinley added a comment -

        +1

        Show
        Ryan McKinley added a comment - +1
        Hide
        Yonik Seeley added a comment -

        Here's a patch that implements the above, in addition to moving from String to BytesRef for getIndexedId() and some other misc cleanups.

        Show
        Yonik Seeley added a comment - Here's a patch that implements the above, in addition to moving from String to BytesRef for getIndexedId() and some other misc cleanups.
        Hide
        Mark Miller added a comment -

        went to do this in the solrcloud branch the other day but it's already been done

        Show
        Mark Miller added a comment - went to do this in the solrcloud branch the other day but it's already been done

          People

          • Assignee:
            Unassigned
            Reporter:
            Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development