Solr
  1. Solr
  2. SOLR-2682

remove addException() from SimpleFacet

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0, 1.2, 1.3, 1.4.1, 3.1, 3.2, 3.3, 4.0-ALPHA
    • Fix Version/s: 3.4, 4.0-ALPHA
    • Component/s: search
    • Labels:
      None

      Description

      addException() which is super historic, pre-apache code, should be removed from SimpleFacet. Hoss described in the mail thread http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201107.mbox/%3Calpine.DEB.2.00.1107281651200.12738@bester%3E

      : If I got an exception during faceting (e.g. undefined field), Solr doesn't
      : return HTTP 400 but 200 with the exception stack trace in <arr name="exception">
      : ...</arr> tag. Why is it implemented so? I checked Solr 1.1 and saw the same behavior.

      super historic, pre-apache, code ... the idea at the time was that some
      parts of the response (like faceting, highlightin, watever...) would be
      "optional" and if there was an error computing that data it wouldn't fail
      the main request.

      that logic should really be ripped out.

      1. SOLR-2682.patch
        6 kB
        Koji Sekiguchi

        Activity

        Hide
        Koji Sekiguchi added a comment -

        Patch.

        I removed addException() in SimpleFacet. SimpleFacet now catches IOException and ParseException and throws them as 500 and 400 errors respectively.

        This affects run time behavior. I wrote a note for it in CHANGES.txt.

        Show
        Koji Sekiguchi added a comment - Patch. I removed addException() in SimpleFacet. SimpleFacet now catches IOException and ParseException and throws them as 500 and 400 errors respectively. This affects run time behavior. I wrote a note for it in CHANGES.txt.
        Hide
        Koji Sekiguchi added a comment -

        I'll commit tomorrow.

        Show
        Koji Sekiguchi added a comment - I'll commit tomorrow.
        Hide
        Koji Sekiguchi added a comment -

        trunk: Committed revision 1152456.
        3x: Committed revision 1152458.

        Show
        Koji Sekiguchi added a comment - trunk: Committed revision 1152456. 3x: Committed revision 1152458.
        Hide
        Yonik Seeley added a comment -

        I think I remember that distributed faceting had explicit support for acting like non-distributed wrt exceptions also.

        Show
        Yonik Seeley added a comment - I think I remember that distributed faceting had explicit support for acting like non-distributed wrt exceptions also.
        Hide
        Koji Sekiguchi added a comment -

        Uh, good point. I'll check.

        Show
        Koji Sekiguchi added a comment - Uh, good point. I'll check.
        Hide
        Robert Muir added a comment -

        bulk close for 3.4

        Show
        Robert Muir added a comment - bulk close for 3.4

          People

          • Assignee:
            Koji Sekiguchi
            Reporter:
            Koji Sekiguchi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development