Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2666

Solrj test.classpath should not include Solr core test compilation output

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.4, 4.0-ALPHA
    • 3.4, 4.0-ALPHA
    • Build
    • None

    Description

      Under solr/solrj/ on branch_3x, ant compile-test fails because of incomplete backport of the SOLR-2452 changes: TestNamedListCodec still depends on a Solr test class TestDistributedSearch.

      This problem is masked by the inclusion of Solr test compilation output in Solrj's test.classpath, which is inherited from solr/common-build.xml; when ant compile-test is run from solr/, the Solr core tests are compiled first, thus allowing Solrj test compilation to succeed.

      On trunk, ant compile-test under solr/solrj/ does not fail, because TestNamedListCodec depends on BaseDistributedSearchTestCase, located in Solr's test-framework, instead of on TestDistributedSearch. This issue should nevertheless be addressed on trunk too, to surface future inadvertent solrj test->solr core test dependencies.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            sarowe Steven Rowe
            sarowe Steven Rowe
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment