Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2666

Solrj test.classpath should not include Solr core test compilation output

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.4, 4.0-ALPHA
    • Fix Version/s: 3.4, 4.0-ALPHA
    • Component/s: Build
    • Labels:
      None

      Description

      Under solr/solrj/ on branch_3x, ant compile-test fails because of incomplete backport of the SOLR-2452 changes: TestNamedListCodec still depends on a Solr test class TestDistributedSearch.

      This problem is masked by the inclusion of Solr test compilation output in Solrj's test.classpath, which is inherited from solr/common-build.xml; when ant compile-test is run from solr/, the Solr core tests are compiled first, thus allowing Solrj test compilation to succeed.

      On trunk, ant compile-test under solr/solrj/ does not fail, because TestNamedListCodec depends on BaseDistributedSearchTestCase, located in Solr's test-framework, instead of on TestDistributedSearch. This issue should nevertheless be addressed on trunk too, to surface future inadvertent solrj test->solr core test dependencies.

        Attachments

          Activity

            People

            • Assignee:
              steve_rowe Steve Rowe
              Reporter:
              steve_rowe Steve Rowe
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: