Solr
  1. Solr
  2. SOLR-2633

Make SolrDispatchFilter testable and add tests

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.1, 3.2, 3.3
    • Fix Version/s: None
    • Component/s: search
    • Labels:
      None

      Description

      I have ideas for possible extensions/enhancements to the SolrDispatchFilter. However, as it doesn't have any tests, making safe enhancements is difficult. Given its monolithic nature, it is hard to test. Therefore, I am proposing to refactor it to make it testable, and to provide tests for it.

      1. SOLR-2633-tests-only.patch
        12 kB
        Edoardo Tosca
      2. SOLR-2633-tests-only.patch
        8 kB
        Edoardo Tosca

        Activity

        Edoardo Tosca created issue -
        Edoardo Tosca made changes -
        Field Original Value New Value
        Affects Version/s 3.3 [ 12316471 ]
        Affects Version/s 4.0 [ 12314992 ]
        Edoardo Tosca made changes -
        Attachment SOLR-2633-tests-only.patch [ 12485297 ]
        Mark Miller made changes -
        Assignee Mark Miller [ markrmiller@gmail.com ]
        Mark Miller made changes -
        Fix Version/s 3.4 [ 12316683 ]
        Fix Version/s 4.0 [ 12314992 ]
        Edoardo Tosca made changes -
        Attachment SOLR-2633-only-tests.patch [ 12485727 ]
        Edoardo Tosca made changes -
        Attachment SOLR-2633-only-tests.patch [ 12485727 ]
        Edoardo Tosca made changes -
        Attachment SOLR-2633-tests-only.patch [ 12485728 ]
        Robert Muir made changes -
        Fix Version/s 3.5 [ 12317876 ]
        Fix Version/s 3.4 [ 12316683 ]
        Simon Willnauer made changes -
        Fix Version/s 3.6 [ 12319065 ]
        Fix Version/s 3.5 [ 12317876 ]
        Robert Muir made changes -
        Fix Version/s 3.6 [ 12319065 ]
        Hoss Man made changes -
        Fix Version/s 4.0 [ 12322455 ]
        Fix Version/s 4.0-ALPHA [ 12314992 ]
        Robert Muir made changes -
        Fix Version/s 4.0 [ 12322551 ]
        Fix Version/s 4.0-BETA [ 12322455 ]
        Hoss Man made changes -
        Fix Version/s 4.0 [ 12322551 ]
        Mark Miller made changes -
        Assignee Mark Miller [ markrmiller@gmail.com ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Edoardo Tosca
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development