Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2591

Remove commitLockTimeout option from solrconfig.xml

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      I've noticed that commitLockTimeout option is loaded by the configuration but no longer used. This issue will be concerned with removing this option from all solrconfig.xml files (including example) and from the SolrConfig class.

      1. SOLR-2591.patch
        19 kB
        Luca Cavanna

        Activity

        Hide
        thetaphi Uwe Schindler added a comment -

        Bulk close after 3.5 is released

        Show
        thetaphi Uwe Schindler added a comment - Bulk close after 3.5 is released
        Hide
        martijn.v.groningen Martijn van Groningen added a comment -

        Committed to trunk and 3x branch.

        Show
        martijn.v.groningen Martijn van Groningen added a comment - Committed to trunk and 3x branch.
        Hide
        cmale Chris Male added a comment -

        +1

        Show
        cmale Chris Male added a comment - +1
        Hide
        martijn.v.groningen Martijn van Groningen added a comment -

        Looks great Luca! This should be committed soon.

        Show
        martijn.v.groningen Martijn van Groningen added a comment - Looks great Luca! This should be committed soon.
        Hide
        lucacavanna Luca Cavanna added a comment - - edited

        I think this unused option can be misleading, so why not remove it?
        I attached a patch for the trunk. I also found out some double use of the same value for writeLockTimeout in configuration files (inside indexDefaults): I could be wrong but I don't think the repetition is useful, so I've fixed it. Please let me know whether the patch looks good or not.

        Show
        lucacavanna Luca Cavanna added a comment - - edited I think this unused option can be misleading, so why not remove it? I attached a patch for the trunk. I also found out some double use of the same value for writeLockTimeout in configuration files (inside indexDefaults): I could be wrong but I don't think the repetition is useful, so I've fixed it. Please let me know whether the patch looks good or not.

          People

          • Assignee:
            martijn.v.groningen Martijn van Groningen
            Reporter:
            martijn.v.groningen Martijn van Groningen
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development