Solr
  1. Solr
  2. SOLR-2589

Commenting out the <arr name="queries"> section in firstSearcher generates an NPE

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Environment:

      All

      Description

      This has been around from at least 1.4.1, it just clutters up the log, it's pretty harmless but easy to fix. I'll get it done as soon as I get my account set up.

      1. SOLR-2589-3x.patch
        8 kB
        Erick Erickson
      2. SOLR-2589.patch
        8 kB
        Erick Erickson
      3. SOLR-2589.patch
        8 kB
        Erick Erickson

        Activity

        Hide
        Erick Erickson added a comment -

        one-liner, the rest is testing. I'd like to put this up this weekend if possible, my first code check-in!

        Show
        Erick Erickson added a comment - one-liner, the rest is testing. I'd like to put this up this weekend if possible, my first code check-in!
        Hide
        Simon Willnauer added a comment -

        Erick, good to see testing for this!
        I wonder if you have an encoding problem I see a <?> in DirectoryFactory (Dir�ctoryFactory) in your patch.
        Regarding the one line change I wonder if you could pull the "queries" named list only once, assign it to a local var and check the var for null. Tiny safe but every bit counts.

        rest looks good I look forward to more patches like that with more test code than actual changes.

        Show
        Simon Willnauer added a comment - Erick, good to see testing for this! I wonder if you have an encoding problem I see a <?> in DirectoryFactory (Dir�ctoryFactory) in your patch. Regarding the one line change I wonder if you could pull the "queries" named list only once, assign it to a local var and check the var for null. Tiny safe but every bit counts. rest looks good I look forward to more patches like that with more test code than actual changes.
        Hide
        Erick Erickson added a comment -

        Ahhh, thanks. I just started using a new machine and think I forgot to
        make sure of that.

        Yeah, I thought of pulling it out into a variable, but this is rarely
        executed code, well, it'd be good for me to do anyway.

        Backport to 3x?

        Erick

        Show
        Erick Erickson added a comment - Ahhh, thanks. I just started using a new machine and think I forgot to make sure of that. Yeah, I thought of pulling it out into a variable, but this is rarely executed code, well, it'd be good for me to do anyway. Backport to 3x? Erick
        Hide
        Simon Willnauer added a comment -

        Backport to 3x?

        yeah thats an easy fix commit to trunk and then merge into 3.x - make sure you read the merge wiki before you merge http://wiki.apache.org/lucene-java/SvnMerge

        simon

        Show
        Simon Willnauer added a comment - Backport to 3x? yeah thats an easy fix commit to trunk and then merge into 3.x - make sure you read the merge wiki before you merge http://wiki.apache.org/lucene-java/SvnMerge simon
        Hide
        Erick Erickson added a comment -

        Turns out that the trunk patch doesn't apply cleanly to the 3x branch, so here are two.

        Show
        Erick Erickson added a comment - Turns out that the trunk patch doesn't apply cleanly to the 3x branch, so here are two.
        Hide
        Erick Erickson added a comment -

        updating source momentarily.

        Show
        Erick Erickson added a comment - updating source momentarily.
        Hide
        Erick Erickson added a comment -

        Forgot to include the issue number in the comment, so it's not showing up here, the revision is r1137092. Here's the ViewVC link: http://svn.apache.org/viewvc?view=revision&revision=r1137092

        Thanks Steve for pointing this out.

        Show
        Erick Erickson added a comment - Forgot to include the issue number in the comment, so it's not showing up here, the revision is r1137092. Here's the ViewVC link: http://svn.apache.org/viewvc?view=revision&revision=r1137092 Thanks Steve for pointing this out.
        Hide
        Robert Muir added a comment -

        Bulk close for 3.3

        Show
        Robert Muir added a comment - Bulk close for 3.3

          People

          • Assignee:
            Erick Erickson
            Reporter:
            Erick Erickson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development