Solr
  1. Solr
  2. SOLR-2572

improve mergepolicy configuration

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 3.3, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      Spinoff from SOLR-2567.

      Currently configuration of a mergepolicy in solr is by lucene classname (must have no-arg ctor), and
      some merge-policy specific configuration parameters are not per-mergepolicy, but instead with the rest of the index configuration.

      I think we should make this more pluggable, so that we can fully configure things like TieredMergePolicy,
      and also so that if someone wants to plug in their own MP they can do that too.

        Issue Links

          Activity

          Robert Muir created issue -
          Robert Muir made changes -
          Field Original Value New Value
          Link This issue blocks SOLR-2567 [ SOLR-2567 ]
          Hide
          Robert Muir added a comment -

          See my note on SOLR-2567, at the moment all merge policies take simple setters with primitive types, so you can actually configure all their parameters already.

          Because of this, I think some factory interface would just be overkill, when you can already just do:

              <mergePolicy class="org.apache.lucene.index.TieredMergePolicy">
                <int name="maxMergeAtOnceExplicit">19</int>
                <int name="segmentsPerTier">9</int>
              </mergePolicy>
          
          Show
          Robert Muir added a comment - See my note on SOLR-2567 , at the moment all merge policies take simple setters with primitive types, so you can actually configure all their parameters already. Because of this, I think some factory interface would just be overkill, when you can already just do: <mergePolicy class="org.apache.lucene.index.TieredMergePolicy"> <int name="maxMergeAtOnceExplicit">19</int> <int name="segmentsPerTier">9</int> </mergePolicy>
          Robert Muir made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Won't Fix [ 2 ]
          Hide
          Robert Muir added a comment -

          Bulk close for 3.3

          Show
          Robert Muir added a comment - Bulk close for 3.3
          Robert Muir made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development