Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5, 5.0
    • Component/s: Build
    • Labels:
      None

      Description

      we should randomize indexwriter settings like lucene tests do, to vary # of segments and such.

      1. SOLR-2570.patch
        5 kB
        Hoss Man
      2. SOLR-2570.patch
        7 kB
        Robert Muir

        Activity

        Robert Muir created issue -
        Hide
        Robert Muir added a comment -

        just a start, creates a randomconfig.incl that test configs can xinclude to get random settings.

        of course tons of tests fail right now, but these can be fixed.

        i only cutover the "solrconfig.xml" in the test directory, makes sense to switch over others too.

        by the way it was somewhat messy to switch over the main one because it appears to serve a dual purposes, both as a default test configuration and as a "LINT" config showing all options... not sure if the latter is truly the case but its annoying since you cannot have comments inside of comments in XML.

        Show
        Robert Muir added a comment - just a start, creates a randomconfig.incl that test configs can xinclude to get random settings. of course tons of tests fail right now, but these can be fixed. i only cutover the "solrconfig.xml" in the test directory, makes sense to switch over others too. by the way it was somewhat messy to switch over the main one because it appears to serve a dual purposes, both as a default test configuration and as a "LINT" config showing all options... not sure if the latter is truly the case but its annoying since you cannot have comments inside of comments in XML.
        Robert Muir made changes -
        Field Original Value New Value
        Attachment SOLR-2570.patch [ 12481104 ]
        Robert Muir made changes -
        Fix Version/s 3.4 [ 12316683 ]
        Fix Version/s 3.3 [ 12316471 ]
        Hide
        Robert Muir added a comment -

        3.4 -> 3.5

        Show
        Robert Muir added a comment - 3.4 -> 3.5
        Robert Muir made changes -
        Fix Version/s 3.5 [ 12317876 ]
        Fix Version/s 3.4 [ 12316683 ]
        Simon Willnauer made changes -
        Fix Version/s 3.6 [ 12319065 ]
        Fix Version/s 3.5 [ 12317876 ]
        Robert Muir made changes -
        Fix Version/s 3.6 [ 12319065 ]
        Robert Muir made changes -
        Fix Version/s 4.1 [ 12321141 ]
        Fix Version/s 4.0 [ 12314992 ]
        Steve Rowe made changes -
        Fix Version/s 4.2 [ 12323893 ]
        Fix Version/s 4.1 [ 12321141 ]
        Robert Muir made changes -
        Fix Version/s 4.3 [ 12324128 ]
        Fix Version/s 4.2 [ 12323893 ]
        Uwe Schindler made changes -
        Fix Version/s 4.4 [ 12324324 ]
        Fix Version/s 4.3 [ 12324128 ]
        Hoss Man made changes -
        Parent SOLR-4950 [ 12654263 ]
        Issue Type Test [ 6 ] Sub-task [ 7 ]
        Hide
        Hoss Man added a comment -

        FYI: I'm going to take the xml include idea and use it in my patch in SOLR-4942, then circle back here and deal with all of hte other index writer config settings (although i think my idea in SOLR-4951 may be an improvement on what's in this patch, need to see how well it works out)

        Show
        Hoss Man added a comment - FYI: I'm going to take the xml include idea and use it in my patch in SOLR-4942 , then circle back here and deal with all of hte other index writer config settings (although i think my idea in SOLR-4951 may be an improvement on what's in this patch, need to see how well it works out)
        Hide
        Steve Rowe added a comment -

        Bulk move 4.4 issues to 4.5 and 5.0

        Show
        Steve Rowe added a comment - Bulk move 4.4 issues to 4.5 and 5.0
        Steve Rowe made changes -
        Fix Version/s 5.0 [ 12321664 ]
        Fix Version/s 4.5 [ 12324743 ]
        Fix Version/s 4.4 [ 12324324 ]
        Hide
        Hoss Man added a comment -

        updated patch taking into account the work already done in SOLR-4942 and SOLR-4951.

        In my limited testing so far, I haven't seen any obvious failures – so i'd like to commit soon and then move forward with using the xml include snippet in more configs (SOLR-4952)

        Show
        Hoss Man added a comment - updated patch taking into account the work already done in SOLR-4942 and SOLR-4951 . In my limited testing so far, I haven't seen any obvious failures – so i'd like to commit soon and then move forward with using the xml include snippet in more configs ( SOLR-4952 )
        Hoss Man made changes -
        Attachment SOLR-2570.patch [ 12595558 ]
        Hide
        Robert Muir added a comment -

        +1

        Show
        Robert Muir added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1510637 from hossman@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1510637 ]

        SOLR-2570: randomize more indexConfig settings in tests

        Show
        ASF subversion and git services added a comment - Commit 1510637 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1510637 ] SOLR-2570 : randomize more indexConfig settings in tests
        Hoss Man committed 1510661 (80 files)
        Reviews: none

        SOLR-2570: randomize more indexConfig settings in tests (merge r1510637)

        Lucene branch_4x
        Hide
        ASF subversion and git services added a comment -

        Commit 1510661 from hossman@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1510661 ]

        SOLR-2570: randomize more indexConfig settings in tests (merge r1510637)

        Show
        ASF subversion and git services added a comment - Commit 1510661 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1510661 ] SOLR-2570 : randomize more indexConfig settings in tests (merge r1510637)
        Hoss Man made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Robert Muir added a comment -

        Thank you!

        Show
        Robert Muir added a comment - Thank you!
        Hide
        Adrien Grand added a comment -

        4.5 release -> bulk close

        Show
        Adrien Grand added a comment - 4.5 release -> bulk close
        Adrien Grand made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Robert Muir
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development