Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5, 6.0
    • Component/s: Build
    • Labels:
      None

      Description

      we should randomize indexwriter settings like lucene tests do, to vary # of segments and such.

      1. SOLR-2570.patch
        5 kB
        Hoss Man
      2. SOLR-2570.patch
        7 kB
        Robert Muir

        Activity

        Hide
        rcmuir Robert Muir added a comment -

        just a start, creates a randomconfig.incl that test configs can xinclude to get random settings.

        of course tons of tests fail right now, but these can be fixed.

        i only cutover the "solrconfig.xml" in the test directory, makes sense to switch over others too.

        by the way it was somewhat messy to switch over the main one because it appears to serve a dual purposes, both as a default test configuration and as a "LINT" config showing all options... not sure if the latter is truly the case but its annoying since you cannot have comments inside of comments in XML.

        Show
        rcmuir Robert Muir added a comment - just a start, creates a randomconfig.incl that test configs can xinclude to get random settings. of course tons of tests fail right now, but these can be fixed. i only cutover the "solrconfig.xml" in the test directory, makes sense to switch over others too. by the way it was somewhat messy to switch over the main one because it appears to serve a dual purposes, both as a default test configuration and as a "LINT" config showing all options... not sure if the latter is truly the case but its annoying since you cannot have comments inside of comments in XML.
        Hide
        rcmuir Robert Muir added a comment -

        3.4 -> 3.5

        Show
        rcmuir Robert Muir added a comment - 3.4 -> 3.5
        Hide
        hossman Hoss Man added a comment -

        FYI: I'm going to take the xml include idea and use it in my patch in SOLR-4942, then circle back here and deal with all of hte other index writer config settings (although i think my idea in SOLR-4951 may be an improvement on what's in this patch, need to see how well it works out)

        Show
        hossman Hoss Man added a comment - FYI: I'm going to take the xml include idea and use it in my patch in SOLR-4942 , then circle back here and deal with all of hte other index writer config settings (although i think my idea in SOLR-4951 may be an improvement on what's in this patch, need to see how well it works out)
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk move 4.4 issues to 4.5 and 5.0

        Show
        steve_rowe Steve Rowe added a comment - Bulk move 4.4 issues to 4.5 and 5.0
        Hide
        hossman Hoss Man added a comment -

        updated patch taking into account the work already done in SOLR-4942 and SOLR-4951.

        In my limited testing so far, I haven't seen any obvious failures – so i'd like to commit soon and then move forward with using the xml include snippet in more configs (SOLR-4952)

        Show
        hossman Hoss Man added a comment - updated patch taking into account the work already done in SOLR-4942 and SOLR-4951 . In my limited testing so far, I haven't seen any obvious failures – so i'd like to commit soon and then move forward with using the xml include snippet in more configs ( SOLR-4952 )
        Hide
        rcmuir Robert Muir added a comment -

        +1

        Show
        rcmuir Robert Muir added a comment - +1
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1510637 from hossman@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1510637 ]

        SOLR-2570: randomize more indexConfig settings in tests

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1510637 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1510637 ] SOLR-2570 : randomize more indexConfig settings in tests
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1510661 from hossman@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1510661 ]

        SOLR-2570: randomize more indexConfig settings in tests (merge r1510637)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1510661 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1510661 ] SOLR-2570 : randomize more indexConfig settings in tests (merge r1510637)
        Hide
        rcmuir Robert Muir added a comment -

        Thank you!

        Show
        rcmuir Robert Muir added a comment - Thank you!
        Hide
        jpountz Adrien Grand added a comment -

        4.5 release -> bulk close

        Show
        jpountz Adrien Grand added a comment - 4.5 release -> bulk close

          People

          • Assignee:
            rcmuir Robert Muir
            Reporter:
            rcmuir Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development