Solr
  1. Solr
  2. SOLR-2552

AbstractSolrTestCase should also assert that all opened SolrIndexSearchers are closed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.2, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    1. SOLR-2552.patch
      3 kB
      Michael McCandless
    2. SOLR-2552.patch
      2 kB
      Michael McCandless

      Activity

      Hide
      Michael McCandless added a comment -

      Patch.

      I'll commit soon, and port to trunk too.

      Show
      Michael McCandless added a comment - Patch. I'll commit soon, and port to trunk too.
      Hide
      Michael McCandless added a comment -

      New patch, also moving the start/endTrackingSearchers to before/afterClass in SolrTestCaseJ4, instead of in init/deleteCore.

      Show
      Michael McCandless added a comment - New patch, also moving the start/endTrackingSearchers to before/afterClass in SolrTestCaseJ4, instead of in init/deleteCore.
      Hide
      Robert Muir added a comment -

      this looks good, maybe this was causing the test meddling that it didnt happen in before/afterClass?

      Show
      Robert Muir added a comment - this looks good, maybe this was causing the test meddling that it didnt happen in before/afterClass?
      Hide
      Michael McCandless added a comment -

      Yes, I believe it was!

      In fact there were two separate things – the first test didn't fail when it should have, and the 2nd test failed to call startTrackingSearchers itself (it inherited the start from the first test).

      Show
      Michael McCandless added a comment - Yes, I believe it was! In fact there were two separate things – the first test didn't fail when it should have, and the 2nd test failed to call startTrackingSearchers itself (it inherited the start from the first test).
      Hide
      Robert Muir added a comment -

      Bulk close for 3.2

      Show
      Robert Muir added a comment - Bulk close for 3.2

        People

        • Assignee:
          Unassigned
          Reporter:
          Michael McCandless
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development