Solr
  1. Solr
  2. SOLR-2542

dataimport global session putVal blank

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: None
    • Labels:

      Description

      ContextImpl.java
        private void putVal(String name, Object val, Map map) {
          if(val == null) map.remove(name);
          else entitySession.put(name, val);
        }
      

      change to

      ContextImpl.java
        private void putVal(String name, Object val, Map map) {
          if(val == null) map.remove(name);
          else map.put(name, val);
        }
      
      1. dataimport-globalSession-bug-solr3.1.patch
        0.6 kB
        Linbin Chen
      2. SOLR-2542.3x.patch
        3 kB
        Mikhail Khludnev
      3. SOLR-2542.4x.patch
        3 kB
        Mikhail Khludnev
      4. SOLR-2542.4x.patch
        3 kB
        Mikhail Khludnev
      5. TestContext.java
        2 kB
        Frank Wesemann
      6. TestContext.java
        2 kB
        Frank Wesemann

        Issue Links

          Activity

          Hide
          Robert Muir added a comment -

          Bulk move 3.2 -> 3.3

          Show
          Robert Muir added a comment - Bulk move 3.2 -> 3.3
          Hide
          Frank Wesemann added a comment -

          JUnitTest for this

          Show
          Frank Wesemann added a comment - JUnitTest for this
          Hide
          Frank Wesemann added a comment -

          Updated to trunk version. Uses changed constructor for SolrWriter.

          Show
          Frank Wesemann added a comment - Updated to trunk version. Uses changed constructor for SolrWriter.
          Hide
          Robert Muir added a comment -

          3.4 -> 3.5

          Show
          Robert Muir added a comment - 3.4 -> 3.5
          Hide
          Lance Norskog added a comment -

          Frank- please make a patch file (or files for 3.x and trunk) for this. Also, do all of the DIH unit tests pass?

          Show
          Lance Norskog added a comment - Frank- please make a patch file (or files for 3.x and trunk) for this. Also, do all of the DIH unit tests pass?
          Hide
          Mikhail Khludnev added a comment -

          attaching 3x patch too. DIH tests are passed at both branches

          Show
          Mikhail Khludnev added a comment - attaching 3x patch too. DIH tests are passed at both branches
          Hide
          Mikhail Khludnev added a comment -

          reattaching 4x patch with feather

          Show
          Mikhail Khludnev added a comment - reattaching 4x patch with feather
          Hide
          Frank Wesemann added a comment -

          thanks Mikhail

          Show
          Frank Wesemann added a comment - thanks Mikhail
          Hide
          Hoss Man added a comment -

          many thanks to Linbin for reporting the bug and providing the initial patch, Frank for following up with tests, and Mikhail for getting everything into handy patch form and continually prodding the committers about these DIH issues.

          Committed revision 1231367.
          Committed revision 1231384.

          Two notes about the final commit:

          • added ASL to the testcase
          • removed @author tag - as a policy we don't use them in lucene/solr
          Show
          Hoss Man added a comment - many thanks to Linbin for reporting the bug and providing the initial patch, Frank for following up with tests, and Mikhail for getting everything into handy patch form and continually prodding the committers about these DIH issues. Committed revision 1231367. Committed revision 1231384. Two notes about the final commit: added ASL to the testcase removed @author tag - as a policy we don't use them in lucene/solr
          Hide
          Frank Wesemann added a comment -

          Excuse me. It's in our Eclipse templates

          Gruß
          Frank

          Show
          Frank Wesemann added a comment - Excuse me. It's in our Eclipse templates Gruß Frank

            People

            • Assignee:
              Linbin Chen
              Reporter:
              Linbin Chen
            • Votes:
              3 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development