Solr
  1. Solr
  2. SOLR-2541

Plugininfo tries to load nodes of type "long"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.4, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Environment:

      all

      Description

      As of version 3.1 Plugininfo adds all nodes whose types are not "lst","str","int","bool","arr","float" or "double" to the children list.

      The type "long" is missing in the NL_TAGS set.
      I assume this a bug because DOMUtil recognizes this type, so I consider it a valid tag in solrconfig.xml
      Maybe it's time for a dtd? Or one may define SolrConfig.nodetypes somewhere.
      I'll add a patch, that extends the NL_TAGS Set.

      1. Solr-2541.patch
        0.7 kB
        Frank Wesemann
      2. PlugininfoTest.java
        6 kB
        Frank Wesemann

        Issue Links

          Activity

          Frank Wesemann created issue -
          Frank Wesemann made changes -
          Field Original Value New Value
          Component/s SearchComponents - other [ 12313214 ]
          Hide
          Frank Wesemann added a comment -

          adds "long" to the NL_TAGS set

          Show
          Frank Wesemann added a comment - adds "long" to the NL_TAGS set
          Frank Wesemann made changes -
          Attachment Solr-2541.patch [ 12480280 ]
          Frank Wesemann made changes -
          Link This issue relates to SOLR-1758 [ SOLR-1758 ]
          Hide
          Frank Wesemann added a comment -

          JUnit tests for PluginInfo

          Show
          Frank Wesemann added a comment - JUnit tests for PluginInfo
          Frank Wesemann made changes -
          Attachment PlugininfoTest.java [ 12481832 ]
          Hide
          Hoss Man added a comment -

          Frank: your assumption was spot on, definitely a bug the way PluginInfo was ignore long.

          thank you so much for the test!

          Committed revision 1144415. - trunk
          Committed revision 1144417. - 3x

          Show
          Hoss Man added a comment - Frank: your assumption was spot on, definitely a bug the way PluginInfo was ignore long. thank you so much for the test! Committed revision 1144415. - trunk Committed revision 1144417. - 3x
          Hoss Man made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Hoss Man [ hossman ]
          Fix Version/s 3.4 [ 12316683 ]
          Fix Version/s 4.0 [ 12314992 ]
          Resolution Fixed [ 1 ]
          Hide
          Frank Wesemann added a comment -

          Thanks for taking this issue, Hoss.
          Btw: Do you know the reason for this change? I regarded the old rule "load/instantiate everything that has a class attribute" as a good practice.

          Show
          Frank Wesemann added a comment - Thanks for taking this issue, Hoss. Btw: Do you know the reason for this change? I regarded the old rule "load/instantiate everything that has a class attribute" as a good practice.
          Hide
          Robert Muir added a comment -

          bulk close for 3.4

          Show
          Robert Muir added a comment - bulk close for 3.4
          Robert Muir made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          45d 1h 29m 1 Hoss Man 08/Jul/11 18:29
          Resolved Resolved Closed Closed
          69d 20h 19m 1 Robert Muir 16/Sep/11 14:48

            People

            • Assignee:
              Hoss Man
              Reporter:
              Frank Wesemann
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development