Solr
  1. Solr
  2. SOLR-2540

CommitWithin as an Update Request parameter

    Details

      Description

      It would be useful to support commitWithin HTTP GET request param on all UpdateRequestHandlers.
      That way, you could set commitWithin on the request (for XML, JSON, CSV, Binary and Extracting handlers) with this syntax:

        curl http://localhost:8983/solr/update/extract?literal.id=123&commitWithin=10000
             -H "Content-Type: application/pdf" --data-binary @file.pdf
      

      PS: The JsonUpdateRequestHandler and BinaryUpdateRequestHandler already support this syntax.

      1. SOLR-2540.patch
        13 kB
        Jan Høydahl
      2. SOLR-2540.patch
        6 kB
        Jan Høydahl
      3. SOLR-2540-branch_3x-fix-tests.patch
        11 kB
        Jan Høydahl
      4. SOLR-2540-fix-tests.patch
        11 kB
        Jan Høydahl

        Issue Links

          Activity

          Jan Høydahl created issue -
          Hide
          Jan Høydahl added a comment -

          First patch which solves this for XML, CSV, Extracting. No new tests added so far.

          Show
          Jan Høydahl added a comment - First patch which solves this for XML, CSV, Extracting. No new tests added so far.
          Jan Høydahl made changes -
          Field Original Value New Value
          Attachment SOLR-2540.patch [ 12480275 ]
          Jan Høydahl made changes -
          Link This issue blocks CONNECTORS-202 [ CONNECTORS-202 ]
          Jan Høydahl made changes -
          Assignee Jan Høydahl [ janhoy ]
          Hide
          Jan Høydahl added a comment -

          Anyone have comments to this? I'll try to add some tests and prepare for commit.

          Show
          Jan Høydahl added a comment - Anyone have comments to this? I'll try to add some tests and prepare for commit.
          Hide
          Jan Høydahl added a comment -

          Updated patch with more tests. Will commit in a day or two

          Show
          Jan Høydahl added a comment - Updated patch with more tests. Will commit in a day or two
          Jan Høydahl made changes -
          Attachment SOLR-2540.patch [ 12493016 ]
          Jan Høydahl made changes -
          Fix Version/s 3.4 [ 12316683 ]
          Fix Version/s 4.0 [ 12314992 ]
          Affects Version/s 3.1 [ 12314371 ]
          Jan Høydahl made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hoss Man added a comment -

          the new ExtractingRequestHandlerTest.testCommitWithin method fails fairly reliable on multiple machines.

          Noted by sarowe on the dev list...

          Subject: Trunk test failure: ExtractingRequestHandlerTest.testCommitWithin() [was: [JENKINS-MAVEN]
              Lucene-Solr-Maven-trunk #239: POMs out of sync]
          
          This is 100% reproducible on my local machine (run from solr/contrib/extraction/):
          
          ant test -Dtestcase=ExtractingRequestHandlerTest -Dtestmethod=testCommitWithin
          -Dtests.seed=-2b35f16e02bddd0d:5c36eb67e44fc16d:-54d0d485d6a45315
          

          ...i can reproduce this failure everytime i try (regardless of seed)

          Show
          Hoss Man added a comment - the new ExtractingRequestHandlerTest.testCommitWithin method fails fairly reliable on multiple machines. Noted by sarowe on the dev list... Subject: Trunk test failure: ExtractingRequestHandlerTest.testCommitWithin() [was: [JENKINS-MAVEN] Lucene-Solr-Maven-trunk #239: POMs out of sync] This is 100% reproducible on my local machine (run from solr/contrib/extraction/): ant test -Dtestcase=ExtractingRequestHandlerTest -Dtestmethod=testCommitWithin -Dtests.seed=-2b35f16e02bddd0d:5c36eb67e44fc16d:-54d0d485d6a45315 ...i can reproduce this failure everytime i try (regardless of seed)
          Hoss Man made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Jan Høydahl added a comment -

          Tried reproducing on my Mac, with Java 1.6.0_26 and ant 1.8.2, but no success.
          Any clue on what environment I need to test at, or what in the test case is the problem?

          Show
          Jan Høydahl added a comment - Tried reproducing on my Mac, with Java 1.6.0_26 and ant 1.8.2, but no success. Any clue on what environment I need to test at, or what in the test case is the problem?
          Hide
          Sami Siren added a comment -

          I get a test failure on Linux/Fedora 14

          java -version says:

          java version "1.6.0_24"
          Java(TM) SE Runtime Environment (build 1.6.0_24-b07)
          Java HotSpot(TM) 64-Bit Server VM (build 19.1-b02, mixed mode)
          

          Console output:

              [junit] 15/09/2011 11:43:16 ص org.apache.solr.SolrTestCaseJ4 assertQ
              [junit] SEVERE: REQUEST FAILED: xpath=//*[@numFound='1']
              [junit] 	xml response was: <?xml version="1.0" encoding="UTF-8"?>
              [junit] <response>
              [junit] <lst name="responseHeader"><int name="status">0</int><int name="QTime">0</int></lst><result name="response" numFound="0" start="0"></result>
              [junit] </response>
              [junit] 
              [junit] 	request was:start=0&q=id:one&qt=standard&rows=20&version=2.2
              [junit] 15/09/2011 11:43:16 ص org.apache.solr.common.SolrException log
              [junit] SEVERE: REQUEST FAILED: start=0&q=id:one&qt=standard&rows=20&version=2.2:java.lang.RuntimeException: REQUEST FAILED: xpath=//*[@numFound='1']
              [junit] 	xml response was: <?xml version="1.0" encoding="UTF-8"?>
              [junit] <response>
              [junit] <lst name="responseHeader"><int name="status">0</int><int name="QTime">0</int></lst><result name="response" numFound="0" start="0"></result>
              [junit] </response>
              [junit] 
              [junit] 	request was:start=0&q=id:one&qt=standard&rows=20&version=2.2
              [junit] 	at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:389)
              [junit] 	at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:363)
              [junit] 	at org.apache.solr.handler.extraction.ExtractingRequestHandlerTest.testCommitWithin(ExtractingRequestHandlerTest.java:306)
              [junit] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
              [junit] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
              [junit] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
              [junit] 	at java.lang.reflect.Method.invoke(Method.java:597)
              [junit] 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
              [junit] 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
              [junit] 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
              [junit] 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
              [junit] 	at org.junit.rules.TestWatchman$1.evaluate(TestWatchman.java:48)
              [junit] 	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
              [junit] 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
              [junit] 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
              [junit] 	at org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:148)
              [junit] 	at org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:50)
              [junit] 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
              [junit] 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
              [junit] 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
              [junit] 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
              [junit] 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
              [junit] 	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
              [junit] 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
              [junit] 	at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
              [junit] 	at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39)
              [junit] 	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:420)
              [junit] 	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:911)
              [junit] 	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:768)
              [junit] 
              [junit] NOTE: reproduce with: ant test -Dtestcase=ExtractingRequestHandlerTest -Dtestmethod=testCommitWithin -Dtests.seed=3746e79385edf73e:c0f1416de85bd9:2704bb4f54230c5d
              [junit] 15/09/2011 11:43:17 ص org.apache.solr.common.SolrException log
              [junit] SEVERE: auto commit error...:java.lang.RuntimeException: org.apache.lucene.util.ThreadInterruptedException: java.lang.InterruptedException: sleep interrupted
              [junit] 	at org.apache.solr.core.SolrCore.getSearcher(SolrCore.java:1138)
              [junit] 	at org.apache.solr.core.SolrCore.getSearcher(SolrCore.java:998)
              [junit] 	at org.apache.solr.update.DirectUpdateHandler2.commit(DirectUpdateHandler2.java:339)
              [junit] 	at org.apache.solr.update.CommitTracker.run(CommitTracker.java:184)
              [junit] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
              [junit] 	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
              [junit] 	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
              [junit] 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:98)
              [junit] 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:206)
              [junit] 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
              [junit] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
              [junit] 	at java.lang.Thread.run(Thread.java:662)
              [junit] Caused by: org.apache.lucene.util.ThreadInterruptedException: java.lang.InterruptedException: sleep interrupted
              [junit] 	at org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:644)
              [junit] 	at org.apache.lucene.index.DirectoryReader.open(DirectoryReader.java:84)
              [junit] 	at org.apache.lucene.index.IndexReader.open(IndexReader.java:496)
              [junit] 	at org.apache.lucene.index.IndexReader.open(IndexReader.java:455)
              [junit] 	at org.apache.solr.core.StandardIndexReaderFactory.newReader(StandardIndexReaderFactory.java:38)
              [junit] 	at org.apache.solr.search.SolrIndexSearcher.<init>(SolrIndexSearcher.java:144)
              [junit] 	at org.apache.solr.core.SolrCore.getSearcher(SolrCore.java:1128)
              [junit] 	... 11 more
              [junit] Caused by: java.lang.InterruptedException: sleep interrupted
              [junit] 	at java.lang.Thread.sleep(Native Method)
              [junit] 	at org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:642)
              [junit] 	... 17 more
              [junit] 
              [junit] NOTE: test params are: codec=RandomCodecProvider: {timestamp=Pulsing(freqCutoff=13 minBlockSize=93 maxBlockSize=241), id=Memory, extractedContent=MockSep, stream_source_info=MockDocValuesCodec, stream_size=MockVariableIntBlock(baseBlockSize=27), stream_name=MockFixedIntBlock(blockSize=170), Content-Encoding=Memory, multiDefault=MockRandom, Content-Type=MockVariableIntBlock(baseBlockSize=27), intDefault=MockDocValuesCodec, resourceName=MockSep}, sim=RandomSimilarityProvider(queryNorm=true,coord=false): {}, locale=ar, timezone=Europe/Skopje
              [junit] NOTE: all tests run in this JVM:
              [junit] [ExtractingRequestHandlerTest]
              [junit] NOTE: Linux 2.6.35.13-92.fc14.x86_64 amd64/Sun Microsystems Inc. 1.6.0_24 (64-bit)/cpus=4,threads=1,free=96695616,total=125698048
              [junit] ------------- ---------------- ---------------
              [junit] Testcase: testCommitWithin(org.apache.solr.handler.extraction.ExtractingRequestHandlerTest):	Caused an ERROR
              [junit] Exception during query
              [junit] java.lang.RuntimeException: Exception during query
              [junit] 	at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:396)
              [junit] 	at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:363)
              [junit] 	at org.apache.solr.handler.extraction.ExtractingRequestHandlerTest.testCommitWithin(ExtractingRequestHandlerTest.java:306)
              [junit] 	at org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:148)
              [junit] 	at org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:50)
              [junit] Caused by: java.lang.RuntimeException: REQUEST FAILED: xpath=//*[@numFound='1']
              [junit] 	xml response was: <?xml version="1.0" encoding="UTF-8"?>
              [junit] <response>
              [junit] <lst name="responseHeader"><int name="status">0</int><int name="QTime">0</int></lst><result name="response" numFound="0" start="0"></result>
              [junit] </response>
              [junit] 
              [junit] 	request was:start=0&q=id:one&qt=standard&rows=20&version=2.2
              [junit] 	at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:389)
              [junit] 
              [junit] 
              [junit] Test org.apache.solr.handler.extraction.ExtractingRequestHandlerTest FAILED
          
          
          Show
          Sami Siren added a comment - I get a test failure on Linux/Fedora 14 java -version says: java version "1.6.0_24" Java(TM) SE Runtime Environment (build 1.6.0_24-b07) Java HotSpot(TM) 64-Bit Server VM (build 19.1-b02, mixed mode) Console output: [junit] 15/09/2011 11:43:16 ص org.apache.solr.SolrTestCaseJ4 assertQ [junit] SEVERE: REQUEST FAILED: xpath= //*[@numFound='1'] [junit] xml response was: <?xml version= "1.0" encoding= "UTF-8" ?> [junit] <response> [junit] <lst name= "responseHeader" >< int name= "status" >0</ int >< int name= "QTime" >0</ int ></lst><result name= "response" numFound= "0" start= "0" ></result> [junit] </response> [junit] [junit] request was:start=0&q=id:one&qt=standard&rows=20&version=2.2 [junit] 15/09/2011 11:43:16 ص org.apache.solr.common.SolrException log [junit] SEVERE: REQUEST FAILED: start=0&q=id:one&qt=standard&rows=20&version=2.2:java.lang.RuntimeException: REQUEST FAILED: xpath= //*[@numFound='1'] [junit] xml response was: <?xml version= "1.0" encoding= "UTF-8" ?> [junit] <response> [junit] <lst name= "responseHeader" >< int name= "status" >0</ int >< int name= "QTime" >0</ int ></lst><result name= "response" numFound= "0" start= "0" ></result> [junit] </response> [junit] [junit] request was:start=0&q=id:one&qt=standard&rows=20&version=2.2 [junit] at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:389) [junit] at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:363) [junit] at org.apache.solr.handler.extraction.ExtractingRequestHandlerTest.testCommitWithin(ExtractingRequestHandlerTest.java:306) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] at java.lang.reflect.Method.invoke(Method.java:597) [junit] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) [junit] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) [junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) [junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) [junit] at org.junit.rules.TestWatchman$1.evaluate(TestWatchman.java:48) [junit] at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) [junit] at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31) [junit] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76) [junit] at org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:148) [junit] at org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:50) [junit] at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) [junit] at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) [junit] at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) [junit] at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) [junit] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) [junit] at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) [junit] at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31) [junit] at org.junit.runners.ParentRunner.run(ParentRunner.java:236) [junit] at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:420) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:911) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:768) [junit] [junit] NOTE: reproduce with: ant test -Dtestcase=ExtractingRequestHandlerTest -Dtestmethod=testCommitWithin -Dtests.seed=3746e79385edf73e:c0f1416de85bd9:2704bb4f54230c5d [junit] 15/09/2011 11:43:17 ص org.apache.solr.common.SolrException log [junit] SEVERE: auto commit error...:java.lang.RuntimeException: org.apache.lucene.util.ThreadInterruptedException: java.lang.InterruptedException: sleep interrupted [junit] at org.apache.solr.core.SolrCore.getSearcher(SolrCore.java:1138) [junit] at org.apache.solr.core.SolrCore.getSearcher(SolrCore.java:998) [junit] at org.apache.solr.update.DirectUpdateHandler2.commit(DirectUpdateHandler2.java:339) [junit] at org.apache.solr.update.CommitTracker.run(CommitTracker.java:184) [junit] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) [junit] at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) [junit] at java.util.concurrent.FutureTask.run(FutureTask.java:138) [junit] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:98) [junit] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:206) [junit] at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [junit] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [junit] at java.lang. Thread .run( Thread .java:662) [junit] Caused by: org.apache.lucene.util.ThreadInterruptedException: java.lang.InterruptedException: sleep interrupted [junit] at org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:644) [junit] at org.apache.lucene.index.DirectoryReader.open(DirectoryReader.java:84) [junit] at org.apache.lucene.index.IndexReader.open(IndexReader.java:496) [junit] at org.apache.lucene.index.IndexReader.open(IndexReader.java:455) [junit] at org.apache.solr.core.StandardIndexReaderFactory.newReader(StandardIndexReaderFactory.java:38) [junit] at org.apache.solr.search.SolrIndexSearcher.<init>(SolrIndexSearcher.java:144) [junit] at org.apache.solr.core.SolrCore.getSearcher(SolrCore.java:1128) [junit] ... 11 more [junit] Caused by: java.lang.InterruptedException: sleep interrupted [junit] at java.lang. Thread .sleep(Native Method) [junit] at org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:642) [junit] ... 17 more [junit] [junit] NOTE: test params are: codec=RandomCodecProvider: {timestamp=Pulsing(freqCutoff=13 minBlockSize=93 maxBlockSize=241), id=Memory, extractedContent=MockSep, stream_source_info=MockDocValuesCodec, stream_size=MockVariableIntBlock(baseBlockSize=27), stream_name=MockFixedIntBlock(blockSize=170), Content-Encoding=Memory, multiDefault=MockRandom, Content-Type=MockVariableIntBlock(baseBlockSize=27), intDefault=MockDocValuesCodec, resourceName=MockSep}, sim=RandomSimilarityProvider(queryNorm= true ,coord= false ): {}, locale=ar, timezone=Europe/Skopje [junit] NOTE: all tests run in this JVM: [junit] [ExtractingRequestHandlerTest] [junit] NOTE: Linux 2.6.35.13-92.fc14.x86_64 amd64/Sun Microsystems Inc. 1.6.0_24 (64-bit)/cpus=4,threads=1,free=96695616,total=125698048 [junit] ------------- ---------------- --------------- [junit] Testcase: testCommitWithin(org.apache.solr.handler.extraction.ExtractingRequestHandlerTest): Caused an ERROR [junit] Exception during query [junit] java.lang.RuntimeException: Exception during query [junit] at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:396) [junit] at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:363) [junit] at org.apache.solr.handler.extraction.ExtractingRequestHandlerTest.testCommitWithin(ExtractingRequestHandlerTest.java:306) [junit] at org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:148) [junit] at org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:50) [junit] Caused by: java.lang.RuntimeException: REQUEST FAILED: xpath= //*[@numFound='1'] [junit] xml response was: <?xml version= "1.0" encoding= "UTF-8" ?> [junit] <response> [junit] <lst name= "responseHeader" >< int name= "status" >0</ int >< int name= "QTime" >0</ int ></lst><result name= "response" numFound= "0" start= "0" ></result> [junit] </response> [junit] [junit] request was:start=0&q=id:one&qt=standard&rows=20&version=2.2 [junit] at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:389) [junit] [junit] [junit] Test org.apache.solr.handler.extraction.ExtractingRequestHandlerTest FAILED
          Hide
          Jan Høydahl added a comment -

          Patch which fixes the commitWithin tests for Extracting and CSV handlers. The problem was that the test timed out on slow servers. We now only test that commiWtihin is set on AddUpdateCommand instead of actually indexing a document.

          This patch must be applied AFTER SOLR-2540.patch

          Show
          Jan Høydahl added a comment - Patch which fixes the commitWithin tests for Extracting and CSV handlers. The problem was that the test timed out on slow servers. We now only test that commiWtihin is set on AddUpdateCommand instead of actually indexing a document. This patch must be applied AFTER SOLR-2540 .patch
          Jan Høydahl made changes -
          Attachment SOLR-2540-fix-tests.patch [ 12494624 ]
          Hide
          Jan Høydahl added a comment -

          The same patch for branch_3x

          Show
          Jan Høydahl added a comment - The same patch for branch_3x
          Jan Høydahl made changes -
          Attachment SOLR-2540-branch_3x-fix-tests.patch [ 12494629 ]
          Hide
          Jan Høydahl added a comment -

          Checked in fixes for trunk (r1171138) and 3x (r1171139)

          Show
          Jan Høydahl added a comment - Checked in fixes for trunk (r1171138) and 3x (r1171139)
          Jan Høydahl made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Robert Muir added a comment -

          bulk close for 3.4

          Show
          Robert Muir added a comment - bulk close for 3.4
          Robert Muir made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Steve Rowe added a comment -

          Hi Jan,

          Both the trunk and the branch_3x Jenkins Maven builds failed last night because the Maven configuration for the solr/contrib/extraction/ module does not depend on solr-core test code, and you just introduced a new solr-core test class BufferingRequestProcessor, as well as test code in Solr Cell that uses this class.

          (BTW, none of the other Solr modules depend on Solr test code in the Maven configuration.)

          Apparently the Ant build system still includes solr-core test classes in the test classpath of the other Solr modules. I think this should be fixed; Solr's test-framework makes this dependency obsolete.

          In the short term, though, can we move the new BufferingRequestProcessor class from solr/core/src/test to solr/test-framework/src/java/? That way, the Maven stuff will work again without having to jump through hoops like publishing a solr-core test jar and making other modules have a test dependency on it (that's the way it worked pre-test-framework).

          Show
          Steve Rowe added a comment - Hi Jan, Both the trunk and the branch_3x Jenkins Maven builds failed last night because the Maven configuration for the solr/contrib/extraction/ module does not depend on solr-core test code, and you just introduced a new solr-core test class BufferingRequestProcessor , as well as test code in Solr Cell that uses this class. (BTW, none of the other Solr modules depend on Solr test code in the Maven configuration.) Apparently the Ant build system still includes solr-core test classes in the test classpath of the other Solr modules. I think this should be fixed; Solr's test-framework makes this dependency obsolete. In the short term, though, can we move the new BufferingRequestProcessor class from solr/core/src/test to solr/test-framework/src/java/ ? That way, the Maven stuff will work again without having to jump through hoops like publishing a solr-core test jar and making other modules have a test dependency on it (that's the way it worked pre-test-framework).
          Hide
          Jan Høydahl added a comment -

          Hi,

          Ah, will look at it again. And yes, the test system should be changed to detect such things during tests.

          Show
          Jan Høydahl added a comment - Hi, Ah, will look at it again. And yes, the test system should be changed to detect such things during tests.
          Jan Høydahl made changes -
          Link This issue is required by SOLR-2771 [ SOLR-2771 ]
          Hide
          Jan Høydahl added a comment -

          See new issue SOLR-2771, leaving this one closed..

          Show
          Jan Høydahl added a comment - See new issue SOLR-2771 , leaving this one closed..
          Gavin made changes -
          Link This issue blocks CONNECTORS-202 [ CONNECTORS-202 ]
          Gavin made changes -
          Link This issue is depended upon by CONNECTORS-202 [ CONNECTORS-202 ]

            People

            • Assignee:
              Jan Høydahl
              Reporter:
              Jan Høydahl
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development