Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2530

Remove Noggit CharArr from FieldType

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      FieldType#indexedToReadable(BytesRef, CharArr) uses a noggit dependency that also spreads into ByteUtils. The uses of this method area all convert to String which makes this extra reference and the dependency unnecessary. I refactored it to simply return string and removed ByteUtils entirely. The only leftover from BytesUtils is a constant, i moved that one to Lucenes UnicodeUtils. I will upload a patch in a second

      Attachments

        1. SOLR-2530.patch
          90 kB
          Simon Willnauer
        2. SOLR-2530.patch
          89 kB
          Simon Willnauer
        3. SOLR-2530.patch
          72 kB
          Robert Muir
        4. SOLR-2530.patch
          51 kB
          Simon Willnauer
        5. SOLR-2530.patch
          47 kB
          Simon Willnauer
        6. SOLR-2530.patch
          37 kB
          Simon Willnauer

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            simonw Simon Willnauer
            simonw Simon Willnauer
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment