Solr
  1. Solr
  2. SOLR-2461

Make QuerySenderListener Public

        Details

        • Type: Improvement Improvement
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 4.0-ALPHA
        • Component/s: None
        • Labels:
          None

          Description

          There are legitimate use-cases for folks to extend QuerySenderListener. For example, at Etsy, we would like toggle warm-up queries according to feature flags in our business logic. Unfortunately, this class is declared with the default access level...

            Activity

            Hide
            Permalink
            Hoss Man added a comment -

            Yeah, i'm not sure that there is any reason why QuerySenderListener and AbstractSolrEventListener were never made public.

            i don't see that there is much extinsible value add beyond the "if (condition) super.method(...)" style delegation, but as you mention: even that has it's advantages.

            if you have other suggestiosn for refactoring the class to be more useful when extending, please feel free to open other issues (and submit patches)

            Committed revision 1095545.

            Show
            Hoss Man added a comment - Yeah, i'm not sure that there is any reason why QuerySenderListener and AbstractSolrEventListener were never made public. i don't see that there is much extinsible value add beyond the "if (condition) super.method(...)" style delegation, but as you mention: even that has it's advantages. if you have other suggestiosn for refactoring the class to be more useful when extending, please feel free to open other issues (and submit patches) Committed revision 1095545.

              People

              • Assignee:
                Hoss Man
                Reporter:
                Giovanni Fernandez-Kincade
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development