Solr
  1. Solr
  2. SOLR-2414

Remove CESU-Hack from PHPSerializedResponseWriter

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1, 3.2, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      When SOLR-2381 is committed we no longer use the Writer supplied by the underlying Servlet Container. We can therefore assume that UTF-8 is not CESU, so the hack in PHPSerilaizedResponseWriter is obsolete.

      We should remove it or at least disable the system property, as this is explained in the Wiki and some people may already used it, now failing with 3.1, as we always produce UTF-8 and if the CESU property is true, the serialized output is suddenly wrong.

      1. SOLR-2414.patch
        4 kB
        Uwe Schindler

        Issue Links

          Activity

          Hide
          Uwe Schindler added a comment -

          Committed trunk revision: 1080038
          Committed 3.x revision: 1080041
          Committed 3.1 revision: 1080042

          Show
          Uwe Schindler added a comment - Committed trunk revision: 1080038 Committed 3.x revision: 1080041 Committed 3.1 revision: 1080042
          Hide
          Grant Ingersoll added a comment -

          Bulk close for 3.1.0 release

          Show
          Grant Ingersoll added a comment - Bulk close for 3.1.0 release

            People

            • Assignee:
              Uwe Schindler
              Reporter:
              Uwe Schindler
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development