Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2414

Remove CESU-Hack from PHPSerializedResponseWriter

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1, 3.2, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      When SOLR-2381 is committed we no longer use the Writer supplied by the underlying Servlet Container. We can therefore assume that UTF-8 is not CESU, so the hack in PHPSerilaizedResponseWriter is obsolete.

      We should remove it or at least disable the system property, as this is explained in the Wiki and some people may already used it, now failing with 3.1, as we always produce UTF-8 and if the CESU property is true, the serialized output is suddenly wrong.

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              uschindler Uwe Schindler
              Reporter:
              uschindler Uwe Schindler

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment