Solr
  1. Solr
  2. SOLR-2413

Cleanup XMLWriter, remove support for version < 2.2

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      XMLWriter includes support for a a pre 1.0 response format where multi-valued fields are not collected together in an <arr> tag.

      One problem is that many tests assume this format.

      In 4.0, lets remove support for the old style XML formats

        Issue Links

          Activity

          Hide
          Ryan McKinley added a comment -

          added to /trunk in #1079963 and updated wiki

          Show
          Ryan McKinley added a comment - added to /trunk in #1079963 and updated wiki
          Hide
          Ryan McKinley added a comment -
          Show
          Ryan McKinley added a comment - will need to update: http://wiki.apache.org/solr/XMLResponseFormat
          Hide
          Ryan McKinley added a comment -

          updated patch that does not remove the 'version' tag, just drops support for version less then 2.2

          I'll make a new ticket to drop the version param

          Show
          Ryan McKinley added a comment - updated patch that does not remove the 'version' tag, just drops support for version less then 2.2 I'll make a new ticket to drop the version param
          Hide
          Ryan McKinley added a comment -

          I'd like to commit this soon... it will make a working version of SOLR-1566 much easier

          Show
          Ryan McKinley added a comment - I'd like to commit this soon... it will make a working version of SOLR-1566 much easier
          Hide
          Ryan McKinley added a comment -

          Here is a patch that removes support for the old version, and fixes tests that depends on it.

          Most of the test chagnes look like this:

          -    assertQ(req("id:100"),"//str[@name='my_s'][.='quoted']");
          +    assertQ(req("id:100"),"//arr[@name='my_s']/str[.='quoted']");
          

          that is rather then just str[@name...] it is now arr[@name...]/str

          This removes the multi version support added in SOLR-59

          Show
          Ryan McKinley added a comment - Here is a patch that removes support for the old version, and fixes tests that depends on it. Most of the test chagnes look like this: - assertQ(req( "id:100" ), " //str[@name='my_s'][.='quoted']" ); + assertQ(req( "id:100" ), " //arr[@name='my_s']/str[.='quoted']" ); that is rather then just str [@name...] it is now arr [@name...] /str This removes the multi version support added in SOLR-59

            People

            • Assignee:
              Ryan McKinley
              Reporter:
              Ryan McKinley
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development