Solr
  1. Solr
  2. SOLR-2405

solrconfig.xml tweaks: add DIH lib & remove facet.date

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1
    • Component/s: None
    • Labels:
      None

      Description

      I reviewed the example solrconfig.xml on branch_3x to see if anything needs addressing prior to release.

      • the <lib/> includes don't bring in the DIH, yet it does for most other contribs. It strictly isn't necessary, but the DIH is probably the most used contrib and some people will want to add a DIH request-handler declaration and expect it to work. I recall someone failed to do this recently on the user list for 3x. FYI the DIH was once included in the solr war by default but that changed.
      • facet.date is deprecated in favor of facet.range. Consequently the /browse interface should use facet.range instead.

      I could submit a patch but I'd like agreement first so I don't waste my time.

        Activity

        Hide
        Yonik Seeley added a comment -

        These changes seem fine to me.

        Show
        Yonik Seeley added a comment - These changes seem fine to me.
        Hide
        David Smiley added a comment -

        The attached patch addresses these two issues. It was actually non-trivial to switch the /browse interface to not use facet.date... a little refactoring was in order.

        And I took care to do the +1MILLIS trick for the range boundaries. That's another issue that just feels wrong; I had to basically hard-code knowledge in generating the UI as to where I needed to adjust for inclusive/exclusive. It would be nice if the facet response included information to generate these ranges simpler.

        Show
        David Smiley added a comment - The attached patch addresses these two issues. It was actually non-trivial to switch the /browse interface to not use facet.date... a little refactoring was in order. And I took care to do the +1MILLIS trick for the range boundaries. That's another issue that just feels wrong; I had to basically hard-code knowledge in generating the UI as to where I needed to adjust for inclusive/exclusive. It would be nice if the facet response included information to generate these ranges simpler.
        Hide
        Robert Muir added a comment -

        Can someone review this? I'm trying to get out an RC.

        I can only really feel comfortable about handling the DIH import,
        I don't speak velocity.

        At least if the DIH import is clear that it won't break anything, maybe someone can commit it?

        Show
        Robert Muir added a comment - Can someone review this? I'm trying to get out an RC. I can only really feel comfortable about handling the DIH import, I don't speak velocity. At least if the DIH import is clear that it won't break anything, maybe someone can commit it?
        Hide
        Yonik Seeley added a comment -

        Committed to 3x.
        We need to merge this to trunk too (the supplied patch wouldn't apply cleanly to trunk).

        Show
        Yonik Seeley added a comment - Committed to 3x. We need to merge this to trunk too (the supplied patch wouldn't apply cleanly to trunk).
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            Unassigned
            Reporter:
            David Smiley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development